Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up Next History - Snapshot and display history entries #3796

Merged
merged 10 commits into from
Mar 24, 2025

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Mar 20, 2025

Description

This snapshots "Up Next" queue and displays them under Settings -> Restore from local history -> Up Next History

Testing Instructions

Test.1 - Snapshot on clearing "Up Next" queue

  1. Fresh install the app
  2. Add a few episodes to "Up Next" queue
  3. Long press mini player and clear queue
  4. Go to Profile -> Settings -> Restore from local history -> Up Next History
  5. ✅ Notice a snapshot entry at the current time with the episodes count

Test.2 - Snapshot on login to old account

  1. Continue from above
  2. Re-add a few episodes to the "Up Next" queue
  3. Login with an existing account with up next queue
  4. Wait until refresh completes
  5. ✅ Notice that a snapshot entry is created for local episodes before login under Profile -> Settings -> Restore from local history -> Up Next History

Screenshots or Screencast

Settings Restore options Up Next History

See screencast in #3796

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added [Type] Feature Adding a new feature. HACK week Developed as a part of HACK week [Area] Up Next [Area] Settings labels Mar 20, 2025
@ashiagr ashiagr added this to the 7.86 milestone Mar 20, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Mar 20, 2025

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 20, 2025

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit70e7304
Direct Downloadpocketcasts-app-prototype-build-pr3796-70e7304.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit70e7304
Direct Downloadpocketcasts-automotive-prototype-build-pr3796-70e7304.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit70e7304
Direct Downloadpocketcasts-wear-prototype-build-pr3796-70e7304.apk

ashiagr added 6 commits March 20, 2025 12:18
(cherry picked from commit ca9c952)
(cherry picked from commit ce27a0e)
(cherry picked from commit 8573a53)
(cherry picked from commit 24b9235)
(cherry picked from commit 75fd3fe)
(cherry picked from commit bcc1155)
(cherry picked from commit e8b6090)
(cherry picked from commit 447a5c3)
@ashiagr ashiagr force-pushed the task/up_next_history_page_ branch from 447a5c3 to 65defa0 Compare March 20, 2025 06:51
@ashiagr ashiagr marked this pull request as ready for review March 20, 2025 07:35
@ashiagr ashiagr requested a review from a team as a code owner March 20, 2025 07:35
@ashiagr ashiagr requested review from MiSikora and removed request for a team March 20, 2025 07:35
Base automatically changed from task/up_next_history_db to main March 24, 2025 03:41
@ashiagr ashiagr merged commit 18a4f04 into main Mar 24, 2025
22 checks passed
@ashiagr ashiagr deleted the task/up_next_history_page_ branch March 24, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Settings [Area] Up Next HACK week Developed as a part of HACK week [Type] Feature Adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants