Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for tumblr-metal failing to download Gradle #1705

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Oct 22, 2024

No description provided.

@mokagio mokagio added this to the 2.35 ❄️ milestone Oct 22, 2024
@mokagio mokagio added the tooling Related to anything that supports the building & maintaining of the project. label Oct 22, 2024
# skip lint in CI as a workaround to the task running in an agent that fails to download the Gradle version this project needs.
# The long term fix is to upgrade Gradle here.
run_lint: is_ci == false
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally duplicated the comment and kept the decision logic outside download_translations as a little attempt to keep the issue visible.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 2.35 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

App Name Simplenote Android
Build TypeDebug
Commitfcd2e08
Direct Downloadsimplenote-android-prototype-build-pr1705-fcd2e08-0192b608-5c89-4c42-ab06-95c052a13569.apk

@mokagio mokagio merged commit 07c9896 into release/2.35 Oct 22, 2024
17 checks passed
@mokagio mokagio deleted the mokagio/workaround-for-gradle-download branch October 22, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants