Bound URL fetch retry pacing - #818
Merged
Merged
Conversation
OpenAI gpt-5.6-sol via OpenCode was used to trace the collector scheduling path and draft the implementation and deterministic tests. Chris Huber reviewed and remains responsible for the change.
OpenAI gpt-5.6-sol via OpenCode was used to repair scoped WordPress formatting and PHPStan findings. Chris Huber reviewed and remains responsible for the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #814
Current Scope
request_delay_mspacing only between retry attempts.Evidence
php tests/smoke-url-site-collector.phppassed 50 assertions, including deterministic clock-driven default throughput, retry pacing, cache-bypass, and canonical snapshot checks.php tests/smoke-url-batch-import.phppassed.homeboy review test static-site-importer --extension wordpress --changed-since origin/main --placement localpassed 12/12 WordPress tests: run1ac1306a-6441-481e-b3b4-4f161de168fa.homeboy review lint static-site-importer --extension wordpress --changed-since origin/main --placement localpassed with zero findings: run8001f26a-7079-48d3-88bb-35ac683bfb6c.npm run test:inventory, PHP syntax checks, andgit diff --checkpassed.Follow-up Required For #814
The hardened URL transport is synchronous, per-IP socket I/O. Actual concurrent acquisition requires an owning transport primitive that preserves validated-IP connection pinning, TLS/SNI verification, response caps, per-hop redirect validation, retry/cache behavior, and deterministic completion-independent collection. This PR deliberately does not claim that concurrency criterion is complete.
Compatibility
request_delay_msremains accepted but now paces only retries; its omitted default is 0.AI Assistance
OpenAI gpt-5.6-sol via OpenCode traced the collector scheduling path, drafted the implementation and deterministic tests, and repaired the scoped lint findings. Chris Huber reviewed and remains responsible for every line.