update: Change WooPayments "Channel" to "Sales Channel" and other channel names #10437
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
There was a problem hiding this comment.
Quick review of the code (language/copy) only, I haven't tested – I trust y'all to effectively test.
The main blocker is how we represent In person vs. In person (POS) in metadata and in UI. Based on the P2 discussion, I was expecting two high-level categories Online store and In-person.
The benefits of that approach are:
- Scales as we add different ways to pay. We can add sub-items for all kinds of online or offline channel.
- Allows for analytics at coarse "online vs in-person" level by having one grouping for all in-person / retail / physical transactions.
- Allows for fine grained analytics by combining
Sales channeland specific attribute.
We might need to go back to design to flesh out how we display the child attribute ("POS" or not in this case), and how we represent it in database.
| value="in_person_pos" | ||
| > | ||
| In-Person (POS) | ||
| </option>, |
There was a problem hiding this comment.
My understanding from the P2 discussion is that we would have two broad categories:
Online storeIn-person
Each category would have more specific variations, like child terms in a taxonomy. The variations would be tracked in custom metadata/attribute. For example:
Online storecredit cardpaypalafterpay- etc
In-person- woo iOS app IPP
- woo / stripe card-reader hardware
- etc
So … I wasn't expecting two separate categories for In-person. I think that's confusing, and doesn't scale – we don't have separate top-level categories for Online store, even though it covers lots of variations.
There was a problem hiding this comment.
I agreed with the sentiment here, but actually this dropdown filter option has been missed in this past PR #9802
So it's a compliment for that PR.
FYI @elizaan36 - is this on y'all's design radar? Maybe we need to add something in the UI for the "new" attribute? Also FYI @mjdeacon for the product point of view. |
Hey @haszari Thanks for flagging this. There has always been a differentiation between In-person and In-person (POS) as far as I remember. What's the issue so I understand? |
For me there are two possible issues:
So for design that might mean …
|
htdat
force-pushed
the
fix/10245-update-channel-texts
branch
from
f807473 to
8d9f428
Compare
|
Size Change: +31 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
|
@haszari - I agreed with your sentiment in your last comment that we should have an additional attribute to represent different origins for channel That said, I think we can scale back this PR to focus on two terms "Sales channel" and "Online store". For the |
There was a problem hiding this comment.
Thanks @htdat! I agree with all that has been said above and keeping the next iteration(s) in a separate PR sounds great.
I have just scanned through the code, but I tested the behavior in the transactions list and I can see IPP/POS/Online transactions and the filters work as expected. 🚢
Happy for the other attribute to be handled in a separate PR (and maybe separate issue), good idea. |
|
Created this issue to discuss the attribute to distinguish different |
Fixes #10245
Changes proposed in this Pull Request
This PR updates the terminology around "Channel" in WooPayments to avoid confusion with WooCommerce core's order attribution "Marketing Channel" concept:
Testing instructions
Look at these pages and confirm new terminologies are applied properly:
Screenshot for the transaction listing + filters:
Screenshot for the transaction detail
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge