chore: remove unnecessary useEffect on settings toggle #10449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frosso
commented
Feb 26, 2025
| @@ -17,14 +16,6 @@ const MultiCurrencyToggle = () => { | |||
| updateIsMultiCurrencyEnabled, | |||
| ] = useMultiCurrency(); | |||
|
|
|||
| const headingRef = useRef( null ); | |||
There was a problem hiding this comment.
headingRef is assigned here - but it's not assigned to a DOM element. Unlike it was done here:
frosso
commented
Feb 26, 2025
| @@ -18,14 +17,6 @@ const WCPaySubscriptionsToggle = () => { | |||
| updateIsWCPaySubscriptionsEnabled, | |||
| ] = useWCPaySubscriptions(); | |||
|
|
|||
| const headingRef = useRef( null ); | |||
frosso
added
the
size: x-small
frosso
requested review from
a team and
mdmoore
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -25 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this Pull Request
I noticed there's a couple of places where we trigger a
useEffecton aref. But therefis never assigned. So theuseEffectwould effectively never run 🤷I think these components were copy/pasted from this older one https://github.com/Automattic/woocommerce-payments/blob/8f24a5d98c6938d88f537fcdfe5435772bb30379/client/settings/advanced-settings/debug-mode.js without realizing that the
headingRefwas never assigned 🤷Testing instructions
There should be nothing to test here.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge