Use shared dispute utility function isRefundable for disputed order notice to improve code quality
#7965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinksi
changed the base branch from
develop
to
fix/7960-transaction-refund-eligible-disputes-only
Jinksi
commented
Jan 3, 2024
| @@ -66,7 +62,7 @@ const DisputedOrderNoticeHandler = ( { chargeId, onDisableOrderRefund } ) => { | |||
| // This may be dead code. Leaving in for now as this is consistent with | |||
| // the logic before this PR. | |||
| // https://github.com/Automattic/woocommerce-payments/pull/7557 | |||
| if ( dispute.status === 'lost' && ! isRefundable ) { | |||
There was a problem hiding this comment.
isRefundable is redundant here since isRefundable('lost') will always be false if dispute.status === 'lost'.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Jinksi
changed the title
isRefundable util function for disputed order notice
|
Size Change: -7 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Jinksi
added
type: technical debt
…ther actions in the future
…o dev/refactor-order-dispute-refundable-util
…o dev/refactor-order-dispute-refundable-util
Base automatically changed from
fix/7960-transaction-refund-eligible-disputes-only
to
develop
January 4, 2024 23:15
Jinksi
changed the title
isRefundable util function for disputed order noticeisRefundable for disputed order notice
Jinksi
changed the title
isRefundable for disputed order noticeisRefundable for disputed order notice to improve code quality
|
SP 0, a followup from #7962 |
brucealdridge
approved these changes
Jan 7, 2024
|
Thanks @brucealdridge. I have confirmed that the flows as described in the PR description are working as expected. Adding to merge queue 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR utilises the shared dispute util function
isRefundableto determine if a disputed order is refundable on the order screen.woocommerce-payments/client/disputes/utils.ts
Lines 75 to 78 in ea14b50
Testing instructions
Note: PR author has confirmed that the following flows are working as expected
4000000000000259at checkout.winning_evidencein the "additional details" field.4000000000001976at checkout.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge