Use shared dispute utility function isRefundable for disputed order notice to improve code quality

changelog/dev-refactor-order-dispute-refundable-util

@@ -0,0 +1,5 @@
+Significance: patch
+Type: dev
+Comment: Not user-facing: refactor's refund eligibility logic for disputed orders
+
+

changelog/fix-7960-transaction-refund-eligible-disputes-only

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Hide the transaction details refund menu for ineligble disputed transactions

client/components/disputed-order-notice/index.js

@@ -14,6 +14,7 @@ import { getDetailsURL } from 'wcpay/components/details-link';
 import {
 	isAwaitingResponse,
 	isInquiry,
+	isRefundable,
 	isUnderReview,
 } from 'wcpay/disputes/utils';
 import { useCharge } from 'wcpay/data';
@@ -30,10 +31,7 @@ const DisputedOrderNoticeHandler = ( { chargeId, onDisableOrderRefund } ) => {
 		if ( ! charge?.dispute ) {
 			return;
 		}
-		// Refunds are only allowed if the dispute is an inquiry or if it's won.
-		const isRefundable =
-			isInquiry( dispute ) || [ 'won' ].includes( dispute.status );
-		if ( ! isRefundable ) {
+		if ( ! isRefundable( dispute.status ) ) {
 			onDisableOrderRefund( dispute.status );
 		}
 	}, [ charge, onDisableOrderRefund ] );
@@ -42,8 +40,6 @@ const DisputedOrderNoticeHandler = ( { chargeId, onDisableOrderRefund } ) => {
 	if ( ! charge?.dispute ) {
 		return null;
 	}
-	const isRefundable =
-		isInquiry( dispute ) || [ 'won' ].includes( dispute.status );
 
 	// Special case the dispute "under review" notice which is much simpler.
 	// (And return early.)
@@ -66,7 +62,7 @@ const DisputedOrderNoticeHandler = ( { chargeId, onDisableOrderRefund } ) => {
 	// This may be dead code. Leaving in for now as this is consistent with
 	// the logic before this PR.
 	// https://github.com/Automattic/woocommerce-payments/pull/7557
-	if ( dispute.status === 'lost' && ! isRefundable ) {
+	if ( dispute.status === 'lost' ) {
 		return (
 			<DisputeOrderLockedNotice
 				message={ __(

client/disputes/utils.ts

@@ -72,6 +72,11 @@ export const isInquiry = ( dispute: Pick< Dispute, 'status' > ): boolean => {
 	return dispute.status.startsWith( 'warning' );
 };
 
+export const isRefundable = ( status: DisputeStatus ): boolean => {
+	// Refundable dispute statuses are one of `warning_needs_response`, `warning_under_review`, `warning_closed` or `won`.
+	return isInquiry( { status } ) || 'won' === status;
+};
+
 /**
  * Returns the dispute fee balance transaction for a dispute if it exists
  * and the deduction has not been reversed.

client/payment-details/summary/index.tsx

@@ -48,6 +48,7 @@ import DisputeStatusChip from 'components/dispute-status-chip';
 import {
 	getDisputeFeeFormatted,
 	isAwaitingResponse,
+	isRefundable,
 } from 'wcpay/disputes/utils';
 import { useAuthorization } from 'wcpay/data';
 import CaptureAuthorizationButton from 'wcpay/components/capture-authorization-button';
@@ -208,6 +209,14 @@ const PaymentDetailsSummary: React.FC< PaymentDetailsSummaryProps > = ( {
 	const disputeFee =
 		charge.dispute && getDisputeFeeFormatted( charge.dispute );
 
+	// If this transaction is disputed, check if it is refundable.  If not, we should hide the refund menu.
+	const isDisputeRefundable = charge.dispute
+		? isRefundable( charge.dispute.status )
+		: true;
+
+	const showRefundMenu =
+		charge.captured && ! charge.refunded && isDisputeRefundable;
+
 	// Use the balance_transaction fee if available. If not (e.g. authorized but not captured), use the application_fee_amount.
 	const transactionFee = charge.balance_transaction
 		? {
@@ -484,7 +493,7 @@ const PaymentDetailsSummary: React.FC< PaymentDetailsSummaryProps > = ( {
 						</div>
 					</div>
 					<div className="payment-details__refund-controls">
-						{ ! charge?.refunded && charge?.captured && (
+						{ showRefundMenu && (
 							<Loadable
 								isLoading={ isLoading }
 								placeholder={ moreVertical }

client/payment-details/summary/test/index.test.tsx

@@ -427,6 +427,13 @@ describe( 'PaymentDetailsSummary', () => {
 		screen.getByRole( 'button', {
 			name: /Accept dispute/,
 		} );
+
+		// Refund menu is not rendered
+		expect(
+			screen.queryByRole( 'button', {
+				name: /Translation actions/i,
+			} )
+		).toBeNull();
 	} );
 
 	test( 'renders the information of a disputed charge when the store/charge currency differ', () => {
@@ -684,6 +691,11 @@ describe( 'PaymentDetailsSummary', () => {
 				name: /Accept/i,
 			} )
 		).toBeNull();
+
+		// Refund menu is rendered
+		screen.getByRole( 'button', {
+			name: /Translation actions/i,
+		} );
 	} );
 
 	test( 'correctly renders dispute details for "under_review" disputes', () => {
@@ -712,6 +724,13 @@ describe( 'PaymentDetailsSummary', () => {
 				name: /Accept/i,
 			} )
 		).toBeNull();
+
+		// Refund menu is not rendered
+		expect(
+			screen.queryByRole( 'button', {
+				name: /Translation actions/i,
+			} )
+		).toBeNull();
 	} );
 
 	test( 'correctly renders dispute details for "accepted" disputes', () => {
@@ -744,6 +763,13 @@ describe( 'PaymentDetailsSummary', () => {
 				name: /Accept/i,
 			} )
 		).toBeNull();
+
+		// Refund menu is not rendered
+		expect(
+			screen.queryByRole( 'button', {
+				name: /Translation actions/i,
+			} )
+		).toBeNull();
 	} );
 
 	test( 'correctly renders dispute details for "lost" disputes', () => {
@@ -777,6 +803,13 @@ describe( 'PaymentDetailsSummary', () => {
 				name: /Accept/i,
 			} )
 		).toBeNull();
+
+		// Refund menu is not rendered
+		expect(
+			screen.queryByRole( 'button', {
+				name: /Translation actions/i,
+			} )
+		).toBeNull();
 	} );
 
 	test( 'correctly renders dispute details for "warning_needs_response" inquiry disputes', () => {
@@ -807,6 +840,11 @@ describe( 'PaymentDetailsSummary', () => {
 		screen.getByRole( 'button', {
 			name: /Issue refund/i,
 		} );
+
+		// Refund menu is rendered
+		screen.getByRole( 'button', {
+			name: /Translation actions/i,
+		} );
 	} );
 
 	test( 'correctly renders dispute details for "warning_under_review" inquiry disputes', () => {
@@ -834,6 +872,11 @@ describe( 'PaymentDetailsSummary', () => {
 				name: /Accept/i,
 			} )
 		).toBeNull();
+
+		// Refund menu is rendered
+		screen.getByRole( 'button', {
+			name: /Translation actions/i,
+		} );
 	} );
 
 	test( 'correctly renders dispute details for "warning_closed" inquiry disputes', () => {
@@ -862,6 +905,11 @@ describe( 'PaymentDetailsSummary', () => {
 				name: /Accept/i,
 			} )
 		).toBeNull();
+
+		// Refund menu is rendered
+		screen.getByRole( 'button', {
+			name: /Translation actions/i,
+		} );
 	} );
 
 	describe( 'order missing notice', () => {