Fix unnecessary gateway import warning in BNPL messaging element class #7977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 5, 2024 09:02
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
timur27
requested review from
a team,
mdmoore and
gpressutto5
and removed request for
a team and
mdmoore
|
Merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7975
Changes proposed in this Pull Request
Class
WC_Payments_Payment_Method_Messaging_Elementis defined within the global namespace. Thus, it doesn't need imports for classes located in the global namespace. One such class isWC_Payment_Gateway_WCPay, which is currently being imported inWC_Payments_Payment_Method_Messaging_Element.Because of the unnecessary import, PHP echoes a warning when the class is loaded for the first time. This happens on the product details page only.This PR fixes the warning by removing the unnecessary import.
Testing instructions
developbranchfix/unnecessary-import-warningand runnpm run down && npm run upnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge