Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary gateway import warning in BNPL messaging element class #7977

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Fix unnecessary gateway import warning in BNPL messaging element class #7977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b62552b
remove unnecessary import statement which leads to a warning when fir…
Jan 5, 2024
181a735
add changelog entry
Jan 5, 2024
be92689
hint the gateway class to the constructor to ensure type safety
Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/fix-unnecessary-import-warning
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: fix

Remove unnecessary import statement which leads to a warning when first loaded
3 changes: 1 addition & 2 deletions includes/class-wc-payments-payment-method-messaging-element.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
if ( ! defined( 'ABSPATH' ) ) {
exit;
}
use WC_Payment_Gateway_WCPay;
/**
* WC_Payments_Payment_Method_Messaging_Element class.
*/
Expand All @@ -35,7 +34,7 @@ class WC_Payments_Payment_Method_Messaging_Element {
* @param WC_Payment_Gateway_WCPay $gateway Gateway instance.
* @return void
*/
public function __construct( WC_Payments_Account $account, $gateway ) {
public function __construct( WC_Payments_Account $account, WC_Payment_Gateway_WCPay $gateway ) {
$this->account = $account;
$this->gateway = $gateway;
}
Expand Down
Loading