Displaying Clearpay instead of Afterpay for UK based stores #7995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +601 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
gpressutto5
force-pushed
the
afterpay-clearpay
branch
from
8273b00 to
86f570e
Compare
gpressutto5
force-pushed
the
afterpay-clearpay
branch
from
4e719ee to
19ba51e
Compare
This reverts commit 19ba51e.
gpressutto5
force-pushed
the
afterpay-clearpay
branch
from
7f02ce1 to
eaff055
Compare
gpressutto5
added
the
status: blocked
gpressutto5
removed
the
status: blocked
gpressutto5
requested review from
a team and
frosso
and removed request for
a team
gpressutto5
commented
Jan 12, 2024
There was a problem hiding this comment.
Removed unnecessary mask and group
gpressutto5
commented
Jan 12, 2024
Comment on lines
+42
to
+46
| { 'GB' === wcpaySettings?.connect?.country ? ( | ||
| <ClearpayIcon /> | ||
| ) : ( | ||
| <AfterpayIcon /> | ||
| ) } |
There was a problem hiding this comment.
We need to use the store country here because the store is not connected to Stripe at this point
frosso
approved these changes
Jan 15, 2024
Co-authored-by: Francesco <[email protected]>
timur27
pushed a commit
that referenced
this pull request
Jan 16, 2024
Co-authored-by: Francesco <[email protected]>
6 tasks
Jinksi
pushed a commit
that referenced
this pull request
Jan 30, 2024
Co-authored-by: Francesco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6425
Changes proposed in this Pull Request
Based on the account country set in Stripe, we should display Clearpay instead of Afterpay everywhere.
Testing instructions
Using this branch and a Stripe account with a UK address access all pages that show payment methods and ensure Clearpay name and logo is used instead of Afterpay. Some pages you should check:
Then update to a Stripe account from the US and ensure we show Afterpay instead of Clearpay.
I recommend using the Jurassic Ninja link bellow twice and creating different stripe test accounts.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge