Recommend WooPayments when there is no available payment gateway #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattallan
requested changes
Jan 17, 2025
changelog.txt
Outdated
| @@ -1,6 +1,7 @@ | |||
| *** WooCommerce Subscriptions Core Changelog *** | |||
|
|
|||
| = 8.0.0 - xxxx-xx-xx = | |||
| * Fix - Recommend WooPayments when there is no available payment gateway | |||
There was a problem hiding this comment.
Suggested change
| * Fix - Recommend WooPayments when there is no available payment gateway | |
| * Fix - Recommend WooPayments when there is no available payment gateway. |
Small nit 😅
There was a problem hiding this comment.
Thanks, fixed on 7695d93.
| @@ -1893,7 +1893,7 @@ public static function add_recurring_payment_gateway_information( $settings ) { | |||
|
|
|||
| if ( ! $payment_gateways_handler::one_gateway_supports( 'subscriptions' ) ) { | |||
| // translators: $1-2: opening and closing tags of a link that takes to Woo marketplace / Stripe product page | |||
| $available_gateways_description = sprintf( __( 'No payment gateways capable of processing automatic subscription payments are enabled. If you would like to process automatic payments, we recommend the %1$sfree Stripe extension%2$s.', 'woocommerce-subscriptions' ), '<strong><a href="https://www.woocommerce.com/products/stripe/">', '</a></strong>' ); | |||
| $available_gateways_description = sprintf( __( 'No %1$spayment gateways capable of processing automatic subscription payments%2$s are enabled. If you would like to process automatic payments, we recommend %3$sWooPayments%4$s.', 'woocommerce-subscriptions' ), '<a href="hhttps://woocommerce.com/document/subscriptions/payment-gateways/">', '</a>', '<strong><a href="https://woocommerce.com/payments/">', '</a></strong>' ); | |||
There was a problem hiding this comment.
I noticed this change was suggested on the issue, but I'm thinking this additional link (payment gateways capable of processing automatic subscription payments) is necessary.
IMO this section feels pretty crowded with links and since this href is already used further down, I think we can remove it. Thoughts?
There was a problem hiding this comment.
Makes sense, removed on b44e0b9.
mattallan
reviewed
Jan 20, 2025
mattallan
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Thanks @alefesouza ! I've just left a suggestion to remove the extra </a> that was left over.
Approving this to be merged once that small issue is fixed :)
Co-authored-by: Matt Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes woocommerce/woocommerce-subscriptions#4023
Description
Recommend WooPayments instead of Stripe when there is no available recurring payment gateway.
How to test this PR
No payment gateways capable of processing automatic subscription payments...message should recommend WooPayments instead of Stripe.Product impact