Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend WooPayments when there is no available payment gateway #766

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Recommend WooPayments when there is no available payment gateway #766

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e644db
Recommend WooPayments when there is no available payment gateway
alefesouza Jan 15, 2025
438143f
Add changelog entry
alefesouza Jan 15, 2025
b44e0b9
Remove duplicated link
alefesouza Jan 18, 2025
7695d93
Fix changelog entry
alefesouza Jan 18, 2025
783661a
Update includes/admin/class-wc-subscriptions-admin.php
alefesouza Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*** WooCommerce Subscriptions Core Changelog ***

= 8.0.0 - xxxx-xx-xx =
* Fix - Recommend WooPayments when there is no available payment gateway
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fix - Recommend WooPayments when there is no available payment gateway
* Fix - Recommend WooPayments when there is no available payment gateway.

Small nit 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed on 7695d93.

* Fix - Safeguards added to the Subscriptions Totals template used in the My Account area, to guard against fatal errors that could arise in unusual conditions.
* Fix - Correctly load product names with HTML on the cart and checkout shipping rates.

Expand Down
2 changes: 1 addition & 1 deletion includes/admin/class-wc-subscriptions-admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1893,7 +1893,7 @@ public static function add_recurring_payment_gateway_information( $settings ) {

if ( ! $payment_gateways_handler::one_gateway_supports( 'subscriptions' ) ) {
// translators: $1-2: opening and closing tags of a link that takes to Woo marketplace / Stripe product page
$available_gateways_description = sprintf( __( 'No payment gateways capable of processing automatic subscription payments are enabled. If you would like to process automatic payments, we recommend the %1$sfree Stripe extension%2$s.', 'woocommerce-subscriptions' ), '<strong><a href="https://www.woocommerce.com/products/stripe/">', '</a></strong>' );
$available_gateways_description = sprintf( __( 'No %1$spayment gateways capable of processing automatic subscription payments%2$s are enabled. If you would like to process automatic payments, we recommend %3$sWooPayments%4$s.', 'woocommerce-subscriptions' ), '<a href="hhttps://woocommerce.com/document/subscriptions/payment-gateways/">', '</a>', '<strong><a href="https://woocommerce.com/payments/">', '</a></strong>' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this change was suggested on the issue, but I'm thinking this additional link (payment gateways capable of processing automatic subscription payments) is necessary.

IMO this section feels pretty crowded with links and since this href is already used further down, I think we can remove it. Thoughts?

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, removed on b44e0b9.

}

$recurring_payment_settings = apply_filters(
Expand Down
Loading