Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow Me: add a button-only mode #1133

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

mattwiebe
Copy link
Contributor

@mattwiebe mattwiebe commented Jan 7, 2025

At long last, you can configure the "Follow Me" button to have a button-only mode.

Fixes #478

Proposed changes:

  • Add a "Button Only Mode" toggle to the block
  • Make button text configurable
  • Add a "Button size" option (follows the Button component's sizes: "small" | "default" | "compact"

The sidebar looks like this now:

Screenshot 2025-01-07 at 13 30 51

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

Before trying this PR, configure various instances of the Follow Me block. Ensure that they render the same way after this branch is run.

After checking this branch out, try out the new functionality and ensure everything behaves properly.

Also make button text and button size configurable
@mattwiebe mattwiebe requested a review from a team January 7, 2025 19:34
@github-actions github-actions bot added [Block] Follow Me [Focus] Editor Changes to the ActivityPub experience in the block editor labels Jan 7, 2025
src/follow-me/edit.js Outdated Show resolved Hide resolved
@obenland
Copy link
Member

obenland commented Jan 8, 2025

Upgrading worked well with the few instances I created ahead of time, nice!

There are some polish opportunities with the button-only mode:

  • With color customizations there are some unexpected results, like the text color not being customizable and text/background color being the inverse.
  • The button maintains margins around it, that make it behave and look different from the Core button block/
image

Is there a way to re-use the Core button and inherit its customizations when in button-only mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Follow Me [Focus] Editor Changes to the ActivityPub experience in the block editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar Follow button customization
3 participants