Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move: Differentiate between internal and external Move #1413

Open
wants to merge 13 commits into
base: trunk
Choose a base branch
from

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented Mar 4, 2025

To better handle different Move use cases, it makes sense to have a different Move function for internal (Move::internally( $from, $to )) and external (Move::externally( $from, $to )) moves.

To better handle the very specific internal Move command, this PR also introduces the Inherit Activity. This Activity allows developers to mark an Activity that would normally stored as Activity-Object, to be handles as the main Activity.

Proposed changes:

  • Two different functions for internal moves (user-id changes, move abandoned users) and external moves (from WordPress to Mastodon).
  • Implement Inherit Activity

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

@pfefferle pfefferle changed the title init Inherit Activity Mar 4, 2025
@pfefferle pfefferle changed the title Inherit Activity Move: Differentiate between internal and external Mar 6, 2025
@pfefferle pfefferle changed the title Move: Differentiate between internal and external Move: Differentiate between internal and external Move Mar 6, 2025
@pfefferle pfefferle requested a review from a team March 6, 2025 10:40
@pfefferle pfefferle self-assigned this Mar 6, 2025
@pfefferle pfefferle marked this pull request as ready for review March 6, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant