Skip to content

Implement Experience Control component #102700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Apr 21, 2025

Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/2078

Proposed Changes

We are building it in the context of Automattic Component, @automattic/components: dhW7zYBamXJIeJIE3wy5f4-fi

We have copied the initial implementation of the rating options on the PR

Testing Instructions

  • Open the A4A live link
  • Reset the preferences by checking the tool for below values:
Screenshot 2025-04-22 at 8 21 39 AM
  • Go to Team > Invite a team member > Verify the feedback form is shown
Screenshot 2025-04-22 at 8 54 34 AM
Screen.Recording.2025-04-22.at.8.54.40.AM.mov

Optional help text:

Screenshot 2025-04-22 at 3 41 39 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin self-assigned this Apr 21, 2025
Copy link

github-actions bot commented Apr 21, 2025

@matticbot
Copy link
Contributor

matticbot commented Apr 21, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a8c/experience-control-component on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Apr 21, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1249 bytes added 📈 [gzipped])

name                       parsed_size           gzip_size
a8c-for-agencies-feedback      +3325 B  (+1.6%)    +1249 B  (+1.9%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@yashwin yashwin force-pushed the add/a8c/experience-control-component branch 2 times, most recently from 1f104b3 to f7fe745 Compare April 22, 2025 10:13
@yashwin yashwin marked this pull request as ready for review April 22, 2025 10:18
@yashwin yashwin requested review from madebynoam and a team April 22, 2025 10:18
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 22, 2025
@yashwin yashwin requested a review from a team April 22, 2025 12:40
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep this component in the context of where it's used if possible, instead of putting it in @automattic/components. We're trying to keep @automattic/components minimal, and we'll be moving many components out of it in the coming weeks/months. Making it reusable is totally fine of course.

Copy link
Contributor

@madebynoam madebynoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a Storybook story for discoverability, and so that we can do a proper check for quality, accessibility, encapsulation, API consistency, etc.

@yashwin yashwin force-pushed the add/a8c/experience-control-component branch from 7211d1d to b19c1db Compare April 23, 2025 05:39
@yashwin
Copy link
Contributor Author

yashwin commented Apr 23, 2025

Please add a Storybook story for discoverability, and so that we can do a proper check for quality, accessibility, encapsulation, API consistency, etc.

Thanks for the callout, @mirka! TIL how to add a Storybook story and test it locally!

Added here: b19c1db

Screenshot 2025-04-23 at 11 01 15 AM

@yashwin yashwin force-pushed the add/a8c/experience-control-component branch from b19c1db to d2cc069 Compare April 25, 2025 04:06
@yashwin yashwin merged commit c1d2f3c into trunk Apr 25, 2025
14 checks passed
@yashwin yashwin deleted the add/a8c/experience-control-component branch April 25, 2025 05:17
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 25, 2025
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay!

@yashwin
Copy link
Contributor Author

yashwin commented Apr 29, 2025

Thanks for the feedback, @mirka!

I'll address in a different PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants