-
Notifications
You must be signed in to change notification settings - Fork 2k
Implement Experience Control component #102700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1249 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
1f104b3
to
f7fe745
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to keep this component in the context of where it's used if possible, instead of putting it in @automattic/components
. We're trying to keep @automattic/components
minimal, and we'll be moving many components out of it in the coming weeks/months. Making it reusable is totally fine of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a Storybook story for discoverability, and so that we can do a proper check for quality, accessibility, encapsulation, API consistency, etc.
7211d1d
to
b19c1db
Compare
b19c1db
to
d2cc069
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay!
Thanks for the feedback, @mirka! I'll address in a different PR. |
Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/2078
Proposed Changes
We are building it in the context of Automattic Component, @automattic/components: dhW7zYBamXJIeJIE3wy5f4-fi
We have copied the initial implementation of the rating options on the PR
Testing Instructions
Screen.Recording.2025-04-22.at.8.54.40.AM.mov
Optional help text:
Pre-merge Checklist