Experience Control: Improve accessibility and minor refactoring

[yashwin]

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/2112

Proposed Changes

This PR addressed the comments we received from @mirka on this PR that implemented the Experience Control on the Automattic package. We copied the initial implementation from the original PR, which wasn't accessibility-friendly. This PR addresses that issue.

Why are these changes being made?

• To address some accessibility missed along with some refactoring.

Testing Instructions

• Follow the instructions on the original PR: Implement Experience Control component #102700 and everything should work as expected.
• Verify the accessibility changes work as expected:

1. VoiceOver when the emojis are focused. You can use System settings > Accessibility > VoiceOver
2. You can use the keyboard to navigate between emojis

Untitled.mov

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-147206

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-147206&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-147206&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~200 bytes added 📈 [gzipped])

name                       parsed_size           gzip_size
a8c-for-agencies-feedback       +855 B  (+0.4%)     +200 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/experience-control-component on your sandbox.

[madebynoam]

Great details! Ty, @yashwin ! Lgtm!

[mirka]

Thanks for the quick follow-up! I'm clarifying a few things first in the Figma thread (dhW7zYBamXJIeJIE3wy5f4-fi-111_846#1193979809) since this is the first time I'm seeing this discussion.

[ciampo]

Given that we're looking to release a new version of the components package soon (#103160), could it be wiser to remove ExperienceControl from the package exports so that we don't release a WIP component? cc @mirka @simison

[mirka]

Given that we're looking to release a new version of the components package soon (#103160), could it be wiser to remove ExperienceControl from the package exports so that we don't release a WIP component?

As a quick fix (?) I moved it to the Unaudited section in Storybook.

[simison]

Thanks @mirka ! I think that's enough, as the component is already imported here:

wp-calypso/client/a8c-for-agencies/components/a4a-feedback/index.tsx

Line 1 in 41cade2

import { FormLabel, ExperienceControl } from '@automattic/components';

Changelog doesn't mention ExperienceControl either, and considering the package is still in a very much "internal use" state, I think we can manage through internal communication that this component is in progress.

[yashwin]

@mirka:

Thanks for the feedback! 🙇

I have addressed all the comments:b49d4a8. Could you please take another look?

[mirka]

I had some minor thoughts about implementation, but the accessibility issues are fixed 🎉

None of the notes are blockers, but we should probably fix the Storybook controlled mode issue since the stories currently look broken.

[yashwin]

Thanks for the review, @mirka!

Do you think we can now remove it from the Unaudited section?

[mirka]

Yes, go ahead 👍

[mirka]

I pushed a fix for the Storybook crashes. Looks like something changed in a recent update.