Preferences: polish tweaks and PR feedback fixes#109805
Open
fditrapani wants to merge 8 commits intotrunkfrom
Open
Preferences: polish tweaks and PR feedback fixes#109805fditrapani wants to merge 8 commits intotrunkfrom
fditrapani wants to merge 8 commits intotrunkfrom
Conversation
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
matticbot
added
the
[Status] Needs Review
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
- Fix double border under last SummaryButton in medium density by skipping border-bottom on :last-child - Use EmptyState component for blocked sites empty state - Replace straight apostrophes with curly quotes per typography guide Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The summary card was using perPage: 1, which only fetched a single site and displayed an incorrect count. Use perPage: 20 to match the blocked sites page and share the same query cache. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When opting into the new dashboard from /me/account, redirect to /me/preferences/hosting-dashboard instead of /me/preferences so the user lands on the equivalent settings screen. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Revert the global SummaryButton :last-child change which removed borders on the Preferences page. Instead, scope the fix to the MCP settings card using a dedicated class and stylesheet. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Update title and icon across the summary card, sub-page header, and route meta. Use commentAuthorAvatar icon instead of wordpress. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add "Choose your AI agent" as a SectionHeader title to the agent selection card, and change the dropdown label to "AI agent". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove redundant description (already in page header) and trailing period from the empty state title. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
20 tasks
fditrapani
force-pushed
the
update/preferences-tweaks
branch
from
b5f61ff to
e846eb6
Compare
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Replace border-bottom with border-block-end per codebase conventions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
9 tasks
Contributor
|
@fditrapani I think we can modify the base EmptyState component to have compact state. We do use DataViews in contexts like the one here and we should handle those consistency. I've opened a PR to do so: #109807. What do you think? Should we revert the changes here? |
| @@ -0,0 +1,3 @@ | |||
| .dashboard-mcp-settings .summary-button.has-density-medium:last-child { | |||
Contributor
There was a problem hiding this comment.
To be honest, I'm not a fan of this style. I would prefer we codify this component into something reusable. It's technically the same problem we had with SummaryButtonList solved again here because it's not used as the wrapper. It would be good if the SummaryButtonList or some type of derivative should support this layout (Card + Buttons). Tough call.
Do we have any plans for this combination of card and buttons elsewhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addressed feedback that came up in #109744.
EmptyStatecomponent for the blocked sites empty state instead of a plain<p>tagperPage: 1which only fetched one site/me/accountto point to/me/preferences/hosting-dashboardinstead of/me/preferencescommentAuthorAvatariconTest plan
/me/preferences— all items should have bottom borders between them/me/preferences/mcp— enable MCP access and confirm no double border under "Site exceptions"/me/preferences/blocked-siteswith no blocked sites — should show EmptyState component/me/preferences— "Account defaults" should show with the person icon, not WordPress logo/me/preferences/defaults— page title should say "Account defaults"/me/preferences/mcp/setup— agent card should have "Choose your AI agent" heading and "AI agent" dropdown label/me/account, opt into the new dashboard — should redirect to/me/preferences/hosting-dashboard🤖 Generated with Claude Code