Dashboard: Add compact variant to EmptyState.Wrapper#109807
Open
StevenDufresne wants to merge 4 commits intotrunkfrom
Open
Dashboard: Add compact variant to EmptyState.Wrapper#109807StevenDufresne wants to merge 4 commits intotrunkfrom
StevenDufresne wants to merge 4 commits intotrunkfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Scope the compact padding reset to break-medium to match the base rule, and use a flat selector instead of nesting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
8 tasks
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #109805
Proposed Changes
isCompactprop toEmptyState.Wrapperthat sizes the wrapper to its content instead of filling the remaining viewport height.EmptyState.Wrapperfor the blocked sites empty state.CompactWrapperStorybook story.Why are these changes being made?
The existing
EmptyState.Wrapperalways expands to fill the viewport, which doesn't suit all contexts. For example, the blocked sites page just needs a simple card-sized empty state. TheisCompactvariant removes themin-heightcalculation and extra padding so the wrapper shrinks to fit its content.This is an alternative approach to #109805, which addresses the same blocked sites empty state.
Testing Instructions
client/dashboard/EmptyState→CompactWrapperstory.EmptyState.Wrapperusage (e.g., empty sites state) is unaffected.Pre-merge Checklist
🤖 Generated with Claude Code