Make machine shape matcher api more extensible #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technici4n
requested changes
Dec 4, 2024
There was a problem hiding this comment.
I like the cleanup of link and unlink, it was long overdue.
Control flow in the multiblock code is already quite tricky, so make sure not to add any unnecessary virtual method, these really add mental overhead. Remember that complexity is the #1 enemy.
.../java/aztech/modern_industrialization/machines/multiblocks/MultiblockMachineBlockEntity.java
Outdated
Show resolved
Hide resolved
.../java/aztech/modern_industrialization/machines/multiblocks/MultiblockMachineBlockEntity.java
Outdated
Show resolved
Hide resolved
.../java/aztech/modern_industrialization/machines/multiblocks/MultiblockMachineBlockEntity.java
Outdated
Show resolved
Hide resolved
.../java/aztech/modern_industrialization/machines/multiblocks/MultiblockMachineBlockEntity.java
Outdated
Show resolved
Hide resolved
.../java/aztech/modern_industrialization/machines/multiblocks/MultiblockMachineBlockEntity.java
Show resolved
Hide resolved
.../java/aztech/modern_industrialization/machines/multiblocks/MultiblockMachineBlockEntity.java
Outdated
Show resolved
Hide resolved
.../java/aztech/modern_industrialization/machines/multiblocks/MultiblockMachineBlockEntity.java
Outdated
Show resolved
Hide resolved
.../java/aztech/modern_industrialization/machines/multiblocks/MultiblockMachineBlockEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/aztech/modern_industrialization/machines/multiblocks/ShapeMatcher.java
Show resolved
Hide resolved
Technici4n
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains some parts of #900