Add validation and single region NVA scenario #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to ensure that starter locations match the number of connectivity regions and introduces an example configuration for a single-region NVA scenario.
- Added a new README file for the full single-region NVA example.
- Documented options for hub networking and noted current limitations with the vWAN module.
Files not reviewed (3)
- templates/platform_landing_zone/examples/full-single-region-nva/hub-and-spoke-vnet.tfvars: Language not supported
- templates/platform_landing_zone/examples/full-single-region-nva/virtual-wan.tfvars: Language not supported
- templates/platform_landing_zone/variables.tf: Language not supported
Comments suppressed due to low confidence (1)
templates/platform_landing_zone/examples/full-single-region-nva/README.md:10
- [nitpick] Consider using the conventional capitalization 'DDoS' instead of 'DDOS' for clarity.
- DDOS Protection Plan
templates/platform_landing_zone/examples/full-single-region-nva/README.md
Outdated
Show resolved
Hide resolved
…a/README.md Co-authored-by: Copilot <[email protected]>
matt-FFFFFF
approved these changes
Mar 20, 2025
5 tasks
ASHR4
added a commit
that referenced
this pull request
Mar 20, 2025
<!-- Thank you for submitting a Pull Request. Please fill out the template below.--> ## Overview/Summary The validation for `starter_locations `within the platform landing zone fails when `connectivity_type` is set to `none`. These validation changes were introduced in PR #225. The issue arises because the validation logic still assesses `var.virtual_wan_virtual_hubs` and `var.hub_and_spoke_vnet_virtual_networks`, even though these variables are not supplied when `connectivity_type` is `none`. ## Testing Evidence Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate). ## As part of this Pull Request I have - [x] Checked for duplicate [Pull Requests](https://github.com/Azure/alz-terraform-accelerator/pulls) - [x] Associated it with relevant [issues](https://github.com/Azure/alz-terraform-accelerator/issues), for tracking and closure. - [x] Ensured my code/branch is up-to-date with the latest changes in the `main` [branch](https://github.com/Azure/alz-terraform-accelerator/tree/main) - [x] Performed testing and provided evidence. - [x] Updated relevant and associated documentation. --------- Co-authored-by: Rhys Ash <[email protected]> Co-authored-by: Jared Holgate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR adds validation for starter locations to match the number of connectivity regions.
It also adds example config for single region NVA sceanrios
This PR fixes/adds/changes/removes
Breaking Changes
None
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
mainbranch