Throw error for optional path parameter #1545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaqiZhang-Dev
changed the title
tadelesh
approved these changes
Jun 3, 2025
JiaqiZhang-Dev
requested review from
RickWinter,
chlowell and
jhendrixMSFT
as code owners
jhendrixMSFT
requested changes
Jun 3, 2025
Member
jhendrixMSFT
left a comment
jhendrixMSFT
left a comment
There was a problem hiding this comment.
This will break our ability to generate KV SDKs. We need to add proper support for optional path params and should wait until the KV tsp files have been updated.
Member
|
close since we decided to add full support for optional path param. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only used for key vault for which Go uses post processing to support it. Not a priority for now. So, emitter should report error if spec uses this feature.
spec: https://github.com/gracewilcox/azure-rest-api-specs/blob/a7cc4073991257a7b68cb7062b5e5b504a787d12/specification/keyvault/Security.KeyVault.Secrets/routes.tsp#L101
resolve: #1575