Skip to content

Throw error for optional path parameter #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JiaqiZhang-Dev wants to merge 3 commits into from
Closed

Throw error for optional path parameter #1545

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64f0ad3
validate optional path
JiaqiZhang-Dev Apr 28, 2025
fed6758
Merge branch 'main' into validate_optional_path
JiaqiZhang-Dev May 27, 2025
963d171
update
JiaqiZhang-Dev May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/typespec-go/src/tcgcadapter/clients.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,10 @@ export class clientAdapter {
adaptedParam = new go.HeaderParameter(paramName, param.serializedName, this.adaptHeaderType(param.type, true), paramKind, byVal, location);
}
} else if (param.kind === 'path') {
if (param.optional) {
// TODO: Optional path parameter only used for key vault. need to add support in the future.
throw new AdapterError('UnsupportedTsp', `unexpected optional path parameter ${param.name}`, param.__raw?.node ?? NoTarget);
}
adaptedParam = new go.PathParameter(paramName, param.serializedName, !param.allowReserved, this.adaptPathParameterType(param.type), paramKind, byVal, location);
} else if (param.kind === 'cookie') {
// TODO: currently we don't have Azure service using cookie parameter. need to add support if needed in the future.
Expand Down