VMware LRO fixes for rotate-vcenter-password, rotate-nsxt-password, and restrict-movement

[jonathanhe-msft]

---

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az vmware private-cloud rotate-vcenter-password, az vmware private-cloud rotate-nsxt-password, and az vmware vm restrict-movement

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
• My extension version conforms to the Extension version schema

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

[azure-client-tools-bot-prd]

❌Azure CLI Extensions Breaking Change Test

❌vmware

rule	cmd_name	rule_message	suggest_message
❌ 1007 - ParaRemove	vmware private-cloud delete-identity-source	cmd vmware private-cloud delete-identity-source removed parameter alias	please add back parameter alias for cmd vmware private-cloud delete-identity-source
❌ 1007 - ParaRemove	vmware private-cloud delete-identity-source	cmd vmware private-cloud delete-identity-source removed parameter domain	please add back parameter domain for cmd vmware private-cloud delete-identity-source
❌ 1007 - ParaRemove	vmware private-cloud deleteidentitysource	cmd vmware private-cloud deleteidentitysource removed parameter alias	please add back parameter alias for cmd vmware private-cloud deleteidentitysource
❌ 1007 - ParaRemove	vmware private-cloud deleteidentitysource	cmd vmware private-cloud deleteidentitysource removed parameter domain	please add back parameter domain for cmd vmware private-cloud deleteidentitysource

[azure-client-tools-bot-prd]

Hi @jonathanhe-msft,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

[azure-client-tools-bot-prd]

Hi @jonathanhe-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

[yonzhan]

Thank you for your contribution! We will review the pull request and get back to you soon.

[github-actions]

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

[github-actions]

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

[github-actions]

• For more info about extension versioning, please refer to Extension version schema

[zhoxing-ms]

I see that many properties have been marked as read-only. May I ask what is the reason? Is this caused by the Swagger change?

[jonathanhe-msft]

It's not due to swagger change as swagger has had these values since it was created.

I believe that it's due to the python version upgrade and aaz-dev-tools upgrades. I have double checked and the properties do exist in swagger, so there could have been upgrades to code-gen tool that now capture these property flags.

[jonathanhe-msft]

When generating the client using aaz-dev, I noticed that new line characters in confirmation texts are escaped with a double \ eg \\n. When I run these commands, the text is formatted incorrectly (does not display as a new line, instead displays the now escaped new line characters. I modified the text manually to revert it back to the new lines. This can be seen in the second to last commit.

Can I get some confirmation that this is incorrectly generated and \n should not be escaped?

[zhoxing-ms]

When generating the client using aaz-dev, I noticed that new line characters in confirmation texts are escaped with a double \ eg \n. When I run these commands, the text is formatted incorrectly (does not display as a new line, instead displays the now escaped new line characters. I modified the text manually to revert it back to the new lines. This can be seen in the second to last commit. Can I get some confirmation that this is incorrectly generated and \n should not be escaped?

@kairu-ms This question seems to be related to aaz-dev~ If so, could you please take a look at this Code Gen related question?

[zhoxing-ms]

Could you please resolve these CI issues?

[kairu-ms]

When generating the client using aaz-dev, I noticed that new line characters in confirmation texts are escaped with a double \ eg \\n. When I run these commands, the text is formatted incorrectly (does not display as a new line, instead displays the now escaped new line characters. I modified the text manually to revert it back to the new lines. This can be seen in the second to last commit.

Can I get some confirmation that this is incorrectly generated and \n should not be escaped?

There’s no need to add \n in help. I think you can sample remove them

[jonathanhe-msft]

When generating the client using aaz-dev, I noticed that new line characters in confirmation texts are escaped with a double \ eg \\n. When I run these commands, the text is formatted incorrectly (does not display as a new line, instead displays the now escaped new line characters. I modified the text manually to revert it back to the new lines. This can be seen in the second to last commit.
Can I get some confirmation that this is incorrectly generated and \n should not be escaped?

There’s no need to add \n in help. I think you can sample remove them

We want to keep the line spacing though. It's a long message and is much more readable when split up

[jonathanhe-msft]

Could you please resolve these CI issues?

I resolved the scan issues by removing what it was calling out (even though it doesn't seem like it's actually a credential).

For the style issues, I removed the unused arguments. For the other errors about Access to a protected member _registered of a client class, can they be addressed in a separate PR? I see that it is an optional check for now and the problem was introduced when Kai helped us convert our extension to use the code-gen tools. I'd like to get this merged first as it is associated with a CRI.

[necusjz]

When generating the client using aaz-dev, I noticed that new line characters in confirmation texts are escaped with a double \ eg \\n. When I run these commands, the text is formatted incorrectly (does not display as a new line, instead displays the now escaped new line characters. I modified the text manually to revert it back to the new lines. This can be seen in the second to last commit.
Can I get some confirmation that this is incorrectly generated and \n should not be escaped?

There’s no need to add \n in help. I think you can sample remove them

We want to keep the line spacing though. It's a long message and is much more readable when split up

@jonathanhe-msft have you tried add a new line by \n\n? E.g.,