Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware LRO fixes for rotate-vcenter-password, rotate-nsxt-password, and restrict-movement #8462

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

VMware LRO fixes for rotate-vcenter-password, rotate-nsxt-password, and restrict-movement #8462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6644252
test with python 3.12.6
jonathanhe-msft Oct 7, 2024
9029daa
Merge branch 'main' of https://github.com/jonathanhe-msft/azure-cli-e…
jonathanhe-msft Jan 30, 2025
c6ec21e
Merge remote-tracking branch 'upstream/main'
jonathanhe-msft Feb 4, 2025
69ef803
Merge remote-tracking branch 'upstream/main'
jonathanhe-msft Feb 6, 2025
3211aab
regenerate commands with 200 response defined for rotate commands
jonathanhe-msft Feb 7, 2025
91dd611
test recordings
jonathanhe-msft Feb 7, 2025
db59329
release and history
jonathanhe-msft Feb 8, 2025
632bf14
review feedback
jonathanhe-msft Feb 19, 2025
cd9643b
latest test recordings
jonathanhe-msft Feb 19, 2025
bc3f834
Merge remote-tracking branch 'upstream/main' into jonathanhe/lro-fix
jonathanhe-msft Feb 27, 2025
7c6d64c
remove secret from recording
jonathanhe-msft Feb 27, 2025
156bd7f
test recordings and secret removal
jonathanhe-msft Feb 27, 2025
b626702
remove unused arguments
jonathanhe-msft Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/vmware/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Release History

## 7.2.0 (2025-02)

- Bump minimum required Az CLI version to `2.67.0`
- Fix parsing errors on response for `az vmware private-cloud rotate-vcenter-password`, `az vmware private-cloud rotate-nsxt-password`, and `az vmware vm restrict-movement`

## 7.1.0 (2024-09)

- Update `--license-key` to optional for `az vmware srm create` and `az vmware srm update`
Expand Down
4 changes: 4 additions & 0 deletions src/vmware/azext_vmware/aaz/latest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,7 @@
#
# Code generated by aaz-dev-tools
# --------------------------------------------------------------------------------------------

# pylint: skip-file
# flake8: noqa

4 changes: 2 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/addon/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ def _build_arguments_schema(cls, *args, **kwargs):
help="Name of the addon for the private cloud",
required=True,
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
options=["-c", "--private-cloud"],
help="Name of the private cloud",
required=True,
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
4 changes: 2 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/addon/_delete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="child_name_1",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
Expand All @@ -54,7 +54,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="name",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
2 changes: 1 addition & 1 deletion src/vmware/azext_vmware/aaz/latest/vmware/addon/_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
help="Name of the private cloud",
required=True,
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
4 changes: 2 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/addon/_show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="child_name_1",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
Expand All @@ -53,7 +53,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="name",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
4 changes: 2 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/addon/_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="child_name_1",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
Expand All @@ -56,7 +56,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="name",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
4 changes: 2 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/authorization/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@ def _build_arguments_schema(cls, *args, **kwargs):
help="Name of the ExpressRoute Circuit Authorization in the private cloud",
required=True,
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
options=["-c", "--private-cloud"],
help="Name of the private cloud",
required=True,
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
4 changes: 2 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/authorization/_delete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="child_name_1",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
Expand All @@ -58,7 +58,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="name",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
2 changes: 1 addition & 1 deletion src/vmware/azext_vmware/aaz/latest/vmware/authorization/_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
help="Name of the private cloud",
required=True,
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
4 changes: 2 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/authorization/_show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="child_name_1",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
Expand All @@ -56,7 +56,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="name",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
4 changes: 2 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/authorization/_wait.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="child_name_1",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
Expand All @@ -55,7 +55,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="name",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
8 changes: 5 additions & 3 deletions src/vmware/azext_vmware/aaz/latest/vmware/cloud_link/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ def _build_arguments_schema(cls, *args, **kwargs):
help="Name of the cloud link resource",
required=True,
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
options=["-c", "--private-cloud"],
help="Name of the private cloud",
required=True,
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down Expand Up @@ -236,7 +236,9 @@ def _build_schema_on_200_201(cls):
serialized_name="provisioningState",
flags={"read_only": True},
)
properties.status = AAZStrType()
properties.status = AAZStrType(
flags={"read_only": True},
)

system_data = cls._schema_on_200_201.system_data
system_data.created_at = AAZStrType(
Expand Down
4 changes: 2 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/cloud_link/_delete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="child_name_1",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
Expand All @@ -61,7 +61,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="name",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
6 changes: 4 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/cloud_link/_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
help="Name of the private cloud",
required=True,
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down Expand Up @@ -193,7 +193,9 @@ def _build_schema_on_200(cls):
serialized_name="provisioningState",
flags={"read_only": True},
)
properties.status = AAZStrType()
properties.status = AAZStrType(
flags={"read_only": True},
)

system_data = cls._schema_on_200.value.Element.system_data
system_data.created_at = AAZStrType(
Expand Down
8 changes: 5 additions & 3 deletions src/vmware/azext_vmware/aaz/latest/vmware/cloud_link/_show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="child_name_1",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
Expand All @@ -59,7 +59,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="name",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down Expand Up @@ -194,7 +194,9 @@ def _build_schema_on_200(cls):
serialized_name="provisioningState",
flags={"read_only": True},
)
properties.status = AAZStrType()
properties.status = AAZStrType(
flags={"read_only": True},
)

system_data = cls._schema_on_200.system_data
system_data.created_at = AAZStrType(
Expand Down
8 changes: 5 additions & 3 deletions src/vmware/azext_vmware/aaz/latest/vmware/cloud_link/_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="child_name_1",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
Expand All @@ -59,7 +59,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="name",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down Expand Up @@ -380,7 +380,9 @@ def _build_schema_cloud_link_read(cls, _schema):
serialized_name="provisioningState",
flags={"read_only": True},
)
properties.status = AAZStrType()
properties.status = AAZStrType(
flags={"read_only": True},
)

system_data = _schema_cloud_link_read.system_data
system_data.created_at = AAZStrType(
Expand Down
8 changes: 5 additions & 3 deletions src/vmware/azext_vmware/aaz/latest/vmware/cloud_link/_wait.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="child_name_1",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
Expand All @@ -55,7 +55,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="name",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down Expand Up @@ -190,7 +190,9 @@ def _build_schema_on_200(cls):
serialized_name="provisioningState",
flags={"read_only": True},
)
properties.status = AAZStrType()
properties.status = AAZStrType(
flags={"read_only": True},
)

system_data = cls._schema_on_200.system_data
system_data.created_at = AAZStrType(
Expand Down
4 changes: 2 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/cluster/_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ def _build_arguments_schema(cls, *args, **kwargs):
help="Name of the cluster in the private cloud",
required=True,
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
options=["-c", "--private-cloud"],
help="Name of the private cloud",
required=True,
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
4 changes: 2 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/cluster/_delete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="child_name_1",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
Expand All @@ -60,7 +60,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="name",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
2 changes: 1 addition & 1 deletion src/vmware/azext_vmware/aaz/latest/vmware/cluster/_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
help="Name of the private cloud",
required=True,
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
4 changes: 2 additions & 2 deletions src/vmware/azext_vmware/aaz/latest/vmware/cluster/_list_zones.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="child_name_1",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.private_cloud = AAZStrArg(
Expand All @@ -58,7 +58,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=True,
id_part="name",
fmt=AAZStrArgFormat(
pattern="^[-\w\._]+$",
pattern="^[-\\w\\._]+$",
),
)
_args_schema.resource_group = AAZResourceGroupNameArg(
Expand Down
Loading
Loading