Fix TryGetLocationForGatewayDiagnostics to use server-side multi-master setting#5640
Draft
Copilot wants to merge 2 commits intousers/nalutripician/issue-5095-contacted-regions-hub-fallbackfrom
Draft
Conversation
…WriteLocations instead of CanUseMultipleWriteLocations Co-authored-by: NaluTripician <27316859+NaluTripician@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on diagnostics null contacted region name
Fix TryGetLocationForGatewayDiagnostics to use server-side multi-master setting
Feb 25, 2026
Contributor
|
Hi @NaluTripician — this PR has been idle for ~62 days. (Copilot-authored sub-PR of #5618, which you own) What's the current ETA / status? Flagging as part of an open-PR cleanup pass; if it's no longer being pursued we can close it. No auto-close — just looking for a status update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TryGetLocationForGatewayDiagnosticswas gated onCanUseMultipleWriteLocations(), which requires both the client opt-in (UseMultipleWriteLocations) and the account setting (EnableMultipleWriteLocations). This caused the method to returnnullfor the region name when using a multi-master account with the client opt-in disabled — a valid configuration that should still produce correct diagnostics.Changes
LocationCache.cs: ReplaceCanUseMultipleWriteLocations()withthis.enableMultipleWriteLocationsinTryGetLocationForGatewayDiagnostics. The hub write region fallback for the default endpoint is an account-topology concern, not a client routing policy concern.LocationCacheTests.cs: AddValidateTryGetLocationForGatewayDiagnosticsOnDefaultEndpointForMultiMasterWithClientOptOutto cover the previously untested asymmetric case: account hasEnableMultipleWriteLocations = truebut client hasUseMultipleWriteLocations = false.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.