-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed container build trigger and cleanup containers #875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are failing some tests, for example here:
Seems we use rapidjson directly from master and have unpredictable builds. Have you considered freezing the library version similarly to how we do for cmake or gtest? I know the library does not really provide tags and is not versioned properly, but we could tie to a specific git ref. What do you think? |
Yes, we do for some of the older distros but we really should be normalized across all distros. Ill see if i can lock down a version that works across all our supported distros The issue is with distros where GCC>=9 (see Tencent/rapidjson#1700) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
dev
Checklist
dev
branch prior to this PR submission.dev
branch.