Swagger correctness fix

[kalyanachakravarthikarri-az]

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

1. What's the purpose of the update?
   • new service onboarding
   • new API version
   • update existing version for new feature
   • update existing version to fix swagger quality issue in s360
   • Other, please clarify
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

• I commit to follow the Breaking Change Policy of "no breaking changes"
• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

• Change to data plane APIs
• Adding new properties
• All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

• Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

  • Adding a new service
  • Adding new API(s)
  • Adding a new API version
    -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

• Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

• If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

[openapi-workflow-bot]

Hi, @kalyanachakravarthikarri-az Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

[openapi-pipeline-app]

Swagger Validation Report

️❌BreakingChange: 70 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
vaults.json	2023-04-01(6ccb8d1)	2023-04-01(main)
bms.json	2021-11-15(6ccb8d1)	2021-11-15(main)
bms.json	2023-01-15(6ccb8d1)	2023-01-15(main)
bms.json	2023-02-01(6ccb8d1)	2023-02-01(main)
bms.json	2023-04-01(6ccb8d1)	2023-04-01(main)

Only 30 items are listed, please refer to log for more details.

Rule	Message
❌ 1020 - AddedEnumValue	The new version is adding enum value(s) 'AlwaysON' from the old version. New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L9642:9 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L9642:9
❌ 1020 - AddedEnumValue	The new version is adding enum value(s) 'AlwaysON' from the old version. New: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L9650:9 Old: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L9650:9
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L8473:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L8473:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4891:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L4891:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed?
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed?
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L5476:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L5476:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L5659:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L5659:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L5854:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L5854:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed?
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed?
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed?
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed?
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L6928:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L6928:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L7264:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L7264:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L7901:7 Old: Microsoft.RecoveryServices/stable/2023-02-01/bms.json#L7901:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L8481:7 Old: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L8481:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L4891:7 Old: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L4891:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed?
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed?
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L5476:7 Old: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L5476:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L5659:7 Old: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L5659:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L5854:7 Old: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L5854:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed?
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed?
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed?
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed?
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L6936:7 Old: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L6936:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L7272:7 Old: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L7272:7
❌ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'softDeleteRetentionPeriod' renamed or removed? New: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L7909:7 Old: Microsoft.RecoveryServices/stable/2023-04-01/bms.json#L7909:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 29 Errors, 0 Warnings failed [Detail]

Tag package-2023-04; Prod region: Deployed

Test run on region: westcentralus; Operation coverage: total: 20, untested: 0, failed: 11, passed: 9

Service API Readiness Test failed. Check pipeline artifact for detail report.

Rule	Message
❌ CLIENT_ERROR	statusCode: 404, errorCode: InvalidResourceType, errorMessage: The resource type 'locations/checkNameAvailability' could not be found in the namespace 'Microsoft.RecoveryServices' for api version '2023-04-01'. The supported api-versions are '2018-01-10'. Source: runtime OperationId: RecoveryServices_CheckNameAvailability
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: location Source: response OperationId: VaultExtendedInfo_CreateOrUpdate
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: tags Source: response OperationId: VaultExtendedInfo_CreateOrUpdate
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: identity Source: response OperationId: VaultExtendedInfo_CreateOrUpdate
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: sku Source: response OperationId: VaultExtendedInfo_CreateOrUpdate
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: location Source: response OperationId: VaultExtendedInfo_Get
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: tags Source: response OperationId: VaultExtendedInfo_Get
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: identity Source: response OperationId: VaultExtendedInfo_Get
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: sku Source: response OperationId: VaultExtendedInfo_Get
❌ CLIENT_ERROR	statusCode: 412, errorCode: undefined, errorMessage: undefined Source: runtime OperationId: VaultExtendedInfo_Update
❌ INVALID_RESPONSE_BODY	Body is required in response but not provided Source: response OperationId: VaultExtendedInfo_Update
❌ CLIENT_ERROR	statusCode: 400, errorCode: undefined, errorMessage: undefined Source: runtime OperationId: VaultCertificates_Create
❌ INVALID_RESPONSE_CODE	The swagger file does not define '400' response code Source: response OperationId: VaultCertificates_Create
❌ CLIENT_ERROR	statusCode: 404, errorCode: ResourceNotFound, errorMessage: Could not perform the operation as VM no longer exists. Stop protecting virtual machine without deleting backup data. More details at http://go.microsoft.com/fwlink/?LinkId=808124 Source: runtime OperationId: RegisteredIdentities_Delete
❌ INVALID_RESPONSE_CODE	The swagger file does not define '404' response code Source: response OperationId: RegisteredIdentities_Delete
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: monitoringSummary Source: response OperationId: ReplicationUsages_List
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: jobsSummary Source: response OperationId: ReplicationUsages_List
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: protectedItemsSummary Source: response OperationId: ReplicationUsages_List
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: storageAccountsCountSummary Source: response OperationId: ReplicationUsages_List
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: protectedItemCount Source: response OperationId: ReplicationUsages_List
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: registeredServersCount Source: response OperationId: ReplicationUsages_List
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: recoveryPlanCount Source: response OperationId: ReplicationUsages_List
❌ CLIENT_ERROR	statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.RecoveryServices/locations/capabilities/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: RecoveryServices_Capabilities
❌ CLIENT_ERROR	statusCode: 400, errorCode: CloudInvalidInputError, errorMessage: The current operation failed due to an internal service error "Invalid input error". Please retry the operation after some time. If the issue persists, please contact Microsoft support. Source: runtime OperationId: GetOperationResult
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: innerError Source: response OperationId: GetOperationResult
❌ CLIENT_ERROR	statusCode: 400, errorCode: CloudInvalidInputError, errorMessage: The current operation failed due to an internal service error "Invalid input error". Please retry the operation after some time. If the issue persists, please contact Microsoft support. Source: runtime OperationId: GetOperationStatus
❌ OBJECT_ADDITIONAL_PROPERTIES	Additional properties not allowed: innerError Source: response OperationId: GetOperationStatus
❌ CLIENT_ERROR	statusCode: 404, errorCode: undefined, errorMessage: undefined Source: runtime OperationId: PrivateLinkResources_Get
❌ INVALID_RESPONSE_BODY	Body is required in response but not provided Source: response OperationId: PrivateLinkResources_Get

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
❌ MISSING_RESOURCE_ID	id is required to return in response of GET/PUT resource calls but not being provided Url: Microsoft.RecoveryServices/stable/2021-11-15/bms.json#L1007:30 ExampleUrl: 2021-11-15/examples/AzureIaasVm/BackupAadProperties_Get.json#L9:15

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
❌ RestBuild error	"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=369895&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 "

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-js - @azure/arm-recoveryservicesbackup - Approved - 11.0.0

+	Interface PrivateLinkServiceConnectionState no longer has parameter actionRequired
+	Interface ProtectedItem no longer has parameter softDeleteRetentionPeriod
+	Type of parameter protectableItemType of interface AzureVmWorkloadProtectableItem is changed from "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "SAPHanaHSR" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance" to "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "HanaHSRContainer" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance"
+	Type of parameter protectableItemType of interface WorkloadProtectableItem is changed from "AzureFileShare" | "IaaSVMProtectableItem" | "Microsoft.ClassicCompute/virtualMachines" | "Microsoft.Compute/virtualMachines" | "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "SAPHanaHSR" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance" to "AzureFileShare" | "IaaSVMProtectableItem" | "Microsoft.ClassicCompute/virtualMachines" | "Microsoft.Compute/virtualMachines" | "AzureVmWorkloadProtectableItem" | "SAPAseSystem" | "SAPHanaDatabase" | "SAPHanaSystem" | "SAPHanaDBInstance" | "HanaHSRContainer" | "SQLAvailabilityGroupContainer" | "SQLDataBase" | "SQLInstance"

❌azure-sdk-for-go - sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup - Approved - 3.0.0

+	Field `SoftDeleteRetentionPeriod` of struct `AzureFileshareProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `AzureIaaSClassicComputeVMProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `AzureIaaSComputeVMProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `AzureIaaSVMProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `AzureSQLProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `AzureVMWorkloadProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `AzureVMWorkloadSAPAseDatabaseProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `AzureVMWorkloadSAPHanaDBInstanceProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `AzureVMWorkloadSAPHanaDatabaseProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `AzureVMWorkloadSQLDatabaseProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `DPMProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `GenericProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `MabFileFolderProtectedItem` has been removed
+	Field `SoftDeleteRetentionPeriod` of struct `ProtectedItem` has been removed

❌azure-sdk-for-python-track2 - track2_azure-mgmt-recoveryservicesbackup - Approved - 6.0.0

+	Model AzureVmWorkloadSAPHanaDBInstanceProtectedItem no longer has parameter soft_delete_retention_period

️🔄 azure-sdk-for-net-track2 inProgress [Detail]

️🔄 azure-sdk-for-python-track2 inProgress [Detail]

️⚠️ azure-sdk-for-java warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 34782dd. SDK Automation 14.0.0

  command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
  cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
  cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
  cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
  cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
  command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

• ️✔️azure-resourcemanager-recoveryservices [View full logs]  [Release SDK Changes]
  • pom.xml
  • azure-resourcemanager-recoveryservices-1.2.0-beta.1-sources.jar
  • azure-resourcemanager-recoveryservices-1.2.0-beta.1.jar
• ️✔️azure-resourcemanager-recoveryservicesbackup [View full logs]  [Release SDK Changes]
  • pom.xml
  • azure-resourcemanager-recoveryservicesbackup-1.2.0-beta.1.jar
  • azure-resourcemanager-recoveryservicesbackup-1.2.0-beta.1-sources.jar

️🔄 azure-sdk-for-go inProgress [Detail]

️🔄 azure-sdk-for-js inProgress [Detail]

️❌ azure-resource-manager-schemas failed [Detail]

• ❌Pipeline Framework Failed [Logs]Release - Generate from 34782dd. Schema Automation 14.0.0

  command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
  cmderr	[initScript.sh]  old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
  cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
  cmderr	[initScript.sh] npm WARN old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
  cmderr	[initScript.sh] npm WARN old lockfile
  warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
  command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  unexpected http status code: 429
  Error: unexpected http status code: 429

• ️✔️recoveryservices [View full logs] 

  error	Fatal error: unexpected http status code: 429
  error	The following packages are still pending:
  error		recoveryservices

️❌ azure-powershell failed [Detail]

• ❌Pipeline Framework Failed [Logs]Release - Generate from 34782dd. SDK Automation 14.0.0

  command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
  command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  SSL error: syscall failure: Broken pipe
  Error: SSL error: syscall failure: Broken pipe

• ️✔️Az.recoveryservices.DefaultTag [View full logs] 
  • Az.RecoveryServices.0.1.0.nupkg

  error	Fatal error: SSL error: syscall failure: Broken pipe
  error	The following packages are still pending:
  error		Az.recoveryservices.DefaultTag
  error		Az.recoveryservicesbackup.DefaultTag

• ❌Az.recoveryservicesbackup.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-resourcemanager-recoveryservices	https://apiview.dev/Assemblies/Review/806627b15cf14c9d9e95dbf83cf5f6e0
Java	azure-resourcemanager-recoveryservicesbackup	https://apiview.dev/Assemblies/Review/5d6d27de1e644575ae9e7067bb449f2e

[openapi-workflow-bot]

The automation detected this Pull Request introduces breaking changes to an existing API version and hence it added the NewApiVersionRequired label. This means you cannot proceed with merging this PR until you complete one of the following action items:

- A) Submit a new PR instead of this one, or modify this PR, so that it introduces a new API version instead of introducing breaking changes to an existing API version. The automation will remove the label once it detects there are no more breaking changes.
- B) OR you can request an approval of the breaking changes, get it reviewed, and approved. The reviewer will add Approved-BreakingChange label if they approve.

For additional guidance, please see https://aka.ms/NewApiVersionRequired

[openapi-workflow-bot]

Hi @kalyanachakravarthikarri-az, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

[openapi-workflow-bot]

Hi @kalyanachakravarthikarri-az, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

[hiaga]

@kalyanachakravarthikarri-az , please fix duplicated schema issue that caused Go sdk generation failure.

error   | PreCheck/DuplicateSchema | Duplicate Schema named 'MultiUserAuthorization' (4 differences):
cmderr	[generator automation-v2] [ERROR] - type: "object" => "string"
cmderr	[generator automation-v2] [ERROR] - properties: {"multiUserAuthorization":{"x-ms-enum":{"name":"MultiUserAuthorization","modelAsString":true},"$ref":"#/components/schemas/MultiUserAuthorization"}} => <none>
cmderr	[generator automation-v2] [ERROR] - enum: <none> => ["Invalid","Enabled","Disabled"]
cmderr	[generator automation-v2] [ERROR] - x-ms-enum: <none> => {"name":"MultiUserAuthorization","modelAsString":true}; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmderr	[generator automation-v2] [ERROR] fatal   | Error: 1 errors occured -- cannot continue.

looking into this

[hiaga]

@kalyanachakravarthikarri-az , please fix duplicated schema issue that caused Go sdk generation failure.

error   | PreCheck/DuplicateSchema | Duplicate Schema named 'MultiUserAuthorization' (4 differences):
cmderr	[generator automation-v2] [ERROR] - type: "object" => "string"
cmderr	[generator automation-v2] [ERROR] - properties: {"multiUserAuthorization":{"x-ms-enum":{"name":"MultiUserAuthorization","modelAsString":true},"$ref":"#/components/schemas/MultiUserAuthorization"}} => <none>
cmderr	[generator automation-v2] [ERROR] - enum: <none> => ["Invalid","Enabled","Disabled"]
cmderr	[generator automation-v2] [ERROR] - x-ms-enum: <none> => {"name":"MultiUserAuthorization","modelAsString":true}; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
cmderr	[generator automation-v2] [ERROR] fatal   | Error: 1 errors occured -- cannot continue.

looking into this

Hi @raych1 , can you pls check, if the duplicate schema issue is now resolved ?

[zedy-wj]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[zedy-wj]

Approved modelValidation as not introduced in this pr.