-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix headers setting on Web, AzureFunction and WebHook activities #26334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Hi @DavidKarlas, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO. |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
Pipeline.json | 2018-06-01(98f0a5a) | 2018-06-01(main) |
Rule | Message |
---|---|
1021 - AddedAdditionalProperties |
The new version adds an 'additionalProperties' element. New: stable/2018-06-01/entityTypes/Pipeline.json#L6851:9 Old: stable/2018-06-01/entityTypes/Pipeline.json#L6851:9 |
1021 - AddedAdditionalProperties |
The new version adds an 'additionalProperties' element. New: stable/2018-06-01/entityTypes/Pipeline.json#L7884:9 Old: stable/2018-06-01/entityTypes/Pipeline.json#L7881:9 |
1021 - AddedAdditionalProperties |
The new version adds an 'additionalProperties' element. New: stable/2018-06-01/entityTypes/Pipeline.json#L7953:9 Old: stable/2018-06-01/entityTypes/Pipeline.json#L7947:9 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
package-2018-06 | package-2018-06(98f0a5a) | package-2018-06(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L46 |
MissingTypeObject |
The schema 'ControlActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L224 |
MissingTypeObject |
The schema 'ExecutionActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L234 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L267 |
MissingTypeObject |
The schema 'CopyActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L1709 |
MissingTypeObject |
The schema 'CopyActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L1748 |
MissingTypeObject |
The schema 'HDInsightHiveActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5697 |
MissingTypeObject |
The schema 'HDInsightHiveActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5716 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5770 |
MissingTypeObject |
The schema 'HDInsightPigActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5789 |
MissingTypeObject |
The schema 'HDInsightPigActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5808 |
MissingTypeObject |
The schema 'HDInsightMapReduceActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5849 |
MissingTypeObject |
The schema 'HDInsightMapReduceActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5868 |
MissingTypeObject |
The schema 'HDInsightStreamingActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5934 |
MissingTypeObject |
The schema 'HDInsightStreamingActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5953 |
MissingTypeObject |
The schema 'HDInsightSparkActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6047 |
MissingTypeObject |
The schema 'HDInsightSparkActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6066 |
MissingTypeObject |
The schema 'ExecuteSSISPackageActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6121 |
MissingTypeObject |
The schema 'ExecuteSSISPackageActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6140 |
MissingTypeObject |
The schema 'CustomActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6456 |
MissingTypeObject |
The schema 'CustomActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6475 |
MissingTypeObject |
The schema 'CustomActivityReferenceObject' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6520 |
MissingTypeObject |
The schema 'SqlServerStoredProcedureActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6545 |
MissingTypeObject |
The schema 'SqlServerStoredProcedureActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6565 |
MissingTypeObject |
The schema 'ExecutePipelineActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6582 |
MissingTypeObject |
The schema 'ExecutePipelineActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6618 |
MissingTypeObject |
The schema 'DeleteActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6638 |
MissingTypeObject |
The schema 'DeleteActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6657 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6665 |
MissingTypeObject |
The schema 'AzureDataExplorerCommandActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6692 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Thank you for your contribution DavidKarlas! We will review the pull request and get back to you soon. |
Please address or respond to feedback from the ARM API reviewer. |
@DavidKarlas Thanks for submiting this PR to fix swagger issues. I am from ADF team, we are based on this changes and validating locally. |
@DavidKarlas we have applied the fix in this PR #27180. Can we close this issue? Let me know if you have any other questions? |
Thank you, btw maybe also look into #26445 |
First of all, sorry for not using templates...
Can someone direct this at Azure Data Factory team, they can create proper PR, opening PR feels like easiest way to explain how to fix this problem...
This is basically fixing Azure/azure-sdk-for-net#39187