Skip to content

Conversation

@vikramkotturu
Copy link
Contributor

@vikramkotturu vikramkotturu commented Feb 26, 2025

SAP Ase Database workload backup support : 2025-02-01

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-10-01 to stable/2025-02-01.
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 26, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Swagger Avocado has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 26, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup Create ApiView timeout. Package is too large and we cannot create ApiView for it.
Java azure-resourcemanager-recoveryservicesbackup https://apiview.dev/Assemblies/Review/a4a183e5963645238761f94a38ed47e9?revisionId=ca25595cb47d433d8ad2e38970c76e6b
JavaScript @azure/arm-recoveryservicesbackup https://apiview.dev/Assemblies/Review/859c2af295154fe6816f57a966fd8dee?revisionId=57d8bb359d3a434ea9286f0fb81d8ad6
Python azure-mgmt-recoveryservicesbackup https://apiview.dev/Assemblies/Review/0a14b8362f694541b56cb19ab03710bd?revisionId=fea7ae81b22a4e17af909f2f4d693fce

@microsoft-github-policy-service microsoft-github-policy-service bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. Recovery Services Backup labels Feb 26, 2025
@vikramkotturu vikramkotturu marked this pull request as ready for review February 26, 2025 13:22
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.RecoveryServices

@razvanbadea-msft
Copy link
Member

Choose a PR Template description and add a description to this pr to have the Purpose of PR and due diligence sections added

@razvanbadea-msft
Copy link
Member

Fix errors from Swagger PrettierCheck

@razvanbadea-msft
Copy link
Member

Check also errors from Swagger Avocado

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 26, 2025
@hiaga hiaga added AzCoreIDC PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels Mar 3, 2025
@vikramkotturu
Copy link
Contributor Author

Fix errors from Swagger PrettierCheck

Fixed this.

@vikramkotturu
Copy link
Contributor Author

Check also errors from Swagger Avocado

[MULTIPLE_DEFAULT_TAGS] is not related to my changes fixed the rest

@vikramkotturu vikramkotturu changed the title Recoveryservicesbackup stable 2025 02 01 Recoveryservicesbackup stable 2025 02 01 to support SAP Ase Database workload backup Mar 4, 2025
@vikramkotturu vikramkotturu changed the title Recoveryservicesbackup stable 2025 02 01 to support SAP Ase Database workload backup SAP Ase Database workload backup support : 2025-02-01 Mar 4, 2025
@vikramkotturu
Copy link
Contributor Author

Choose a PR Template description and add a description to this pr to have the Purpose of PR and due diligence sections added

I have tried this multiple times but the "Click Here" option just doesn't seem to work. I have updated the heading and initial description to relflect changes, let me know if there is anything else that I need to update.

@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 6, 2025
@vikramkotturu
Copy link
Contributor Author

This PR has no new APIs or breaking changes. It is model additions for supporting backup for ASE DB which is already in preview, the service side functionality has been deployed and in production for about 8 months, and accessible via raw RESt contracts. This swagger is more for SDK and CLI support.

@v-anishrao v-anishrao added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 11, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review AzCoreIDC customer-reported Issues that are reported by GitHub users external to the Azure organization. new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. Recovery Services Backup resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants