Skip to content

[DO NOT REVIEW] [DO NOT MERGE] Fileshares 2024 01 01 preview #34351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

[DO NOT REVIEW] [DO NOT MERGE] Fileshares 2024 01 01 preview #34351

wants to merge 49 commits into from
+6,172 −0

Conversation

ankushbindlish2
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 29, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the CI-RpaaSRPNotInPrivateRepo label.
  • ❌ This PR has CI-RpaaSRPNotInPrivateRepo label. This means it is introducing a new RP (Resource Provider) namespace to the main branch without first merging the new RP to the RPSaaSMaster branch. To resolve, first submit and merge a PR with the new RP namespace to the RPSaaSMasterbranch.This PR will remain blocked until then.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 29, 2025 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.FileShares
Go sdk/resourcemanager/fileshares/armfileshares
Python azure-mgmt-fileshares
Swagger Microsoft.FileShares

This was referenced Apr 29, 2025
Draft
Draft
Draft
This was referenced Apr 29, 2025
Draft
Draft
@ankushbindlish2 ankushbindlish2 requested a review from Copilot April 29, 2025 23:11
Copilot
Copilot AI reviewed Apr 29, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces configuration updates for the Fileshares service preview in preparation for upcoming releases.

  • Adds a cspell configuration file to manage spelling dictionaries.
  • Introduces a new tspconfig.yaml configuration file for various language emitters to generate the Fileshares API SDK.

Reviewed Changes

Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.

File Description
specification/fileshares/cspell.yaml Added import and custom word list entries for the spelling dictionary.
specification/fileshares/FileShares.Management/tspconfig.yaml Added configuration options for multiple language emitters for the Fileshares API.
Files not reviewed (9)
  • specification/fileshares/FileShares.Management/examples/FileShares_Create.json: Language not supported
  • specification/fileshares/FileShares.Management/examples/FileShares_Delete.json: Language not supported
  • specification/fileshares/FileShares.Management/examples/FileShares_Get.json: Language not supported
  • specification/fileshares/FileShares.Management/examples/FileShares_ListByResourceGroup.json: Language not supported
  • specification/fileshares/FileShares.Management/examples/FileShares_ListBySubscription.json: Language not supported
  • specification/fileshares/FileShares.Management/examples/FileShares_Update.json: Language not supported
  • specification/fileshares/FileShares.Management/examples/LocationOperationStatus_Get.json: Language not supported
  • specification/fileshares/FileShares.Management/examples/Operations_List.json: Language not supported
  • specification/fileshares/FileShares.Management/main.tsp: Language not supported

@AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test SuppressionReviewRequired labels May 1, 2025
@JiaqiZhang-Dev
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@JiaqiZhang-Dev
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@JiaqiZhang-Dev
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@tadelesh
Copy link
Member

tadelesh commented May 6, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@tadelesh
Copy link
Member

tadelesh commented May 6, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

ankushbindlish2 and others added 11 commits May 6, 2025 10:04
@ankushbindlish2
java sdk
d2b6d4a
@ankushbindlish2
Merge branch 'fileshares-2024-01-01-preview' of https://github.com/an…
9541cbc 
…kushbindlish2/azure-rest-api-specs into fileshares-2024-01-01-preview
@ankushbindlish2
Merge branch 'main' into fileshares-2024-01-01-preview
e67215a
@ankushbindlish2
Update client.tsp
62b0ea8
@ankushbindlish2
Merge branch 'fileshares-2024-01-01-preview' of https://github.com/an…
c8652ae 
…kushbindlish2/azure-rest-api-specs into fileshares-2024-01-01-preview
@ankushbindlish2
Merge branch 'main' into fileshares-2024-01-01-preview
1369b97
@ankushbindlish2
Remove Languages from ReadMe https://aka.ms/azsdk/spec-gen-sdk-config
adf6543
@ankushbindlish2
Merge branch 'main' into fileshares-2024-01-01-preview
9994e08
@ankushbindlish2
Update readme.md
259b0f8
@ankushbindlish2
Merge branch 'fileshares-2024-01-01-preview' of https://github.com/an…
1bd65de 
…kushbindlish2/azure-rest-api-specs into fileshares-2024-01-01-preview
@ankushbindlish2
Update client.tsp
23e3408
@ankushbindlish2 ankushbindlish2 changed the title [DO NOT MERGE] Fileshares 2024 01 01 preview [DO NOT REVIEW] [DO NOT MERGE] Fileshares 2024 01 01 preview May 8, 2025
@azure-sdk azure-sdk mentioned this pull request May 8, 2025
Draft
live1206
live1206 reviewed May 9, 2025
View reviewed changes
specification/fileshares/FileShares.Management/client.tsp
"csharp"
);

@@clientName(Azure.ResourceManager.CommonTypes.Operation, "Info", "csharp");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be renamed to OperationInfo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@live1206 live1206 live1206 left review comments

Copilot code review Copilot Copilot left review comments

@msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh is a code owner

@jsntcy jsntcy Awaiting requested review from jsntcy

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ARMReview CI-RpaaSRPNotInPrivateRepo new-api-version new-rp-namespace NotReadyForARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ankushbindlish2 @JiaqiZhang-Dev @tadelesh @live1206 @AzureRestAPISpecReview