-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[DO NOT REVIEW] [DO NOT MERGE] Fileshares 2024 01 01 preview #34351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ankushbindlish2
wants to merge
49
commits into
Azure:main
Choose a base branch
from
ankushbindlish2:fileshares-2024-01-01-preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
982ff2c
Kristian Changes
ankushbindlish2 f1f9c33
Fixing tsp validate errors
ankushbindlish2 7e4d273
Remove preflight
ankushbindlish2 350fe62
Merge branch 'main' into fileshares-2024-01-01-preview
ankushbindlish2 3b97864
Formatting
ankushbindlish2 071fbaa
Merge branch 'fileshares-2024-01-01-preview' of https://github.com/an…
ankushbindlish2 ff817fb
Update tspconfig
ankushbindlish2 3807471
Merge branch 'main' into fileshares-2024-01-01-preview
ankushbindlish2 dc6c651
Add Examples
ankushbindlish2 3687c5b
Merge branch 'fileshares-2024-01-01-preview' of https://github.com/an…
ankushbindlish2 178b1a8
revert
ankushbindlish2 4c58329
Merge branch 'main' into fileshares-2024-01-01-preview
ankushbindlish2 72b64f8
update
ankushbindlish2 ca73f59
Update FileShares_ListByFileShare_MaximumSet_Gen.json
ankushbindlish2 e1a4e5f
add examples in tsp
ankushbindlish2 0079600
updtae
ankushbindlish2 d59768c
fix examples
ankushbindlish2 6ce0df2
update
ankushbindlish2 ebe4a2b
Merge branch 'main' into fileshares-2024-01-01-preview
ankushbindlish2 84d0a98
Update
ankushbindlish2 df06874
pretty check
ankushbindlish2 2adf4cd
Merge branch 'main' into fileshares-2024-01-01-preview
ankushbindlish2 e4ebc1d
prettier
ankushbindlish2 c9dbc81
Merge branch 'fileshares-2024-01-01-preview' of https://github.com/an…
ankushbindlish2 1618e36
readme files
ankushbindlish2 8d34982
Lint-diff
ankushbindlish2 e2cc87d
Lint-diff
ankushbindlish2 604b15d
lint-diff
ankushbindlish2 3e5947c
Update readme.md
ankushbindlish2 838f698
update examples
ankushbindlish2 0a71e76
Merge branch 'main' into fileshares-2024-01-01-preview
ankushbindlish2 1a78e44
Update readme.md
ankushbindlish2 6997e1a
Update readme.md
ankushbindlish2 296753f
Update readme.md
ankushbindlish2 b28eda5
Merge branch 'main' into fileshares-2024-01-01-preview
ankushbindlish2 d2b6d4a
java sdk
ankushbindlish2 9541cbc
Merge branch 'fileshares-2024-01-01-preview' of https://github.com/an…
ankushbindlish2 e67215a
Merge branch 'main' into fileshares-2024-01-01-preview
ankushbindlish2 62b0ea8
Update client.tsp
ankushbindlish2 c8652ae
Merge branch 'fileshares-2024-01-01-preview' of https://github.com/an…
ankushbindlish2 1369b97
Merge branch 'main' into fileshares-2024-01-01-preview
ankushbindlish2 adf6543
Remove Languages from ReadMe https://aka.ms/azsdk/spec-gen-sdk-config
ankushbindlish2 9994e08
Merge branch 'main' into fileshares-2024-01-01-preview
ankushbindlish2 259b0f8
Update readme.md
ankushbindlish2 1bd65de
Merge branch 'fileshares-2024-01-01-preview' of https://github.com/an…
ankushbindlish2 23e3408
Update client.tsp
ankushbindlish2 8667255
Update client.tsp
ankushbindlish2 4540928
Update client.tsp
ankushbindlish2 7076d9c
Merge branch 'main' into fileshares-2024-01-01-preview
ankushbindlish2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import "./main.tsp"; | ||
| import "@azure-tools/typespec-client-generator-core"; | ||
|
|
||
| using Azure.ClientGenerator.Core; | ||
| using Azure.ResourceManager.Foundations; | ||
|
|
||
| @@clientName(Microsoft.FileShares, "FileSharesManagementClient", "java"); | ||
|
|
||
| @@clientName(CheckNameAvailabilityResponse, | ||
| "CheckNameAvailabilityResult", | ||
| "csharp" | ||
| ); | ||
|
|
||
| @@clientName(Azure.ResourceManager.CommonTypes.Operation, "Info", "csharp"); | ||
22 changes: 22 additions & 0 deletions
22
...nagement/examples/2023-01-01-preview/FileShares_CheckNameAvailability_MaximumSet_Gen.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "title": "FileShares_CheckNameAvailability_MaximumSet", | ||
| "operationId": "FileShares_CheckNameAvailability", | ||
| "parameters": { | ||
| "api-version": "2023-01-01-preview", | ||
| "subscriptionId": "44EEA578-10B8-4489-8B60-2F8BA982F1E2", | ||
| "location": "westus", | ||
| "body": { | ||
| "name": "mqlepzvhxzskylkwdxbmxcemtbyvh", | ||
| "type": "qoqvzhhkxgfr" | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "nameAvailable": true, | ||
| "reason": "Invalid", | ||
| "message": "lssnd" | ||
| } | ||
| } | ||
| } | ||
| } |
15 changes: 15 additions & 0 deletions
15
...nagement/examples/2023-01-01-preview/FileShares_CheckNameAvailability_MinimumSet_Gen.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "title": "FileShares_CheckNameAvailability_MinimumSet", | ||
| "operationId": "FileShares_CheckNameAvailability", | ||
| "parameters": { | ||
| "api-version": "2023-01-01-preview", | ||
| "subscriptionId": "44EEA578-10B8-4489-8B60-2F8BA982F1E2", | ||
| "location": "westus", | ||
| "body": {} | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": {} | ||
| } | ||
| } | ||
| } |
128 changes: 128 additions & 0 deletions
128
...ares.Management/examples/2023-01-01-preview/FileShares_CreateOrUpdate_MaximumSet_Gen.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| { | ||
| "title": "FileShares_CreateOrUpdate_MaximumSet", | ||
| "operationId": "FileShares_CreateOrUpdate", | ||
| "parameters": { | ||
| "api-version": "2023-01-01-preview", | ||
| "subscriptionId": "44EEA578-10B8-4489-8B60-2F8BA982F1E2", | ||
| "resourceGroupName": "rgfileshares", | ||
| "resourceName": "testfileshare", | ||
| "resource": { | ||
| "properties": { | ||
| "shareName": "testfileshare", | ||
| "tier": "SSD", | ||
| "redundancy": "Local", | ||
| "protocols": [ | ||
| "NFS" | ||
| ], | ||
| "provisionedStorageGiB": 80013, | ||
| "nfsProtocolProperties": { | ||
| "rootSquash": "NoRootSquash" | ||
| }, | ||
| "publicEndpointNetworkRuleSet": { | ||
| "virtualNetworkRules": [ | ||
| { | ||
| "id": "szgchxzvtnnmgmxwrblakajghfxt" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "tags": { | ||
| "key3533": "tagValue" | ||
| }, | ||
| "location": "ijgwtizkwlhftlkpisezexdrkrffy" | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "shareName": "testfileshare", | ||
| "hostName": "fs-vlp5bkznznf0dkb4z.z16.file.storage.azure.net", | ||
| "tier": "SSD", | ||
| "redundancy": "Local", | ||
| "protocols": [ | ||
| "NFS" | ||
| ], | ||
| "provisionedStorageGiB": 80013, | ||
| "provisionedIOPerSec": 16293, | ||
| "provisionedThroughputMiBPerSec": 6721016643, | ||
| "includedBurstIOPerSec": 65925, | ||
| "maxBurstIOPerSecCredits": 0, | ||
| "nfsProtocolProperties": { | ||
| "rootSquash": "NoRootSquash" | ||
| }, | ||
| "publicEndpointNetworkRuleSet": { | ||
| "virtualNetworkRules": [ | ||
| { | ||
| "id": "szgchxzvtnnmgmxwrblakajghfxt" | ||
| } | ||
| ] | ||
| }, | ||
| "provisioningState": "Succeeded" | ||
| }, | ||
| "tags": { | ||
| "key3533": "tagValue" | ||
| }, | ||
| "location": "ijgwtizkwlhftlkpisezexdrkrffy", | ||
| "id": "/subscriptions/11111111-2222-3333-4444-555555555555/resourceGroups/rg1Network/providers/Microsoft.FileShares/fileShares/ankushb-pe-fs-01", | ||
| "name": "testfileshare", | ||
| "type": "Microsoft.FileShares/fileShares", | ||
| "systemData": { | ||
| "createdBy": "testuser", | ||
| "createdByType": "User", | ||
| "createdAt": "2025-04-29T23:32:13.130Z", | ||
| "lastModifiedBy": "kjn", | ||
| "lastModifiedByType": "User", | ||
| "lastModifiedAt": "2025-04-29T23:32:13.131Z" | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "headers": { | ||
| "Azure-AsyncOperation": "https://contoso.com/operationstatus" | ||
| }, | ||
| "body": { | ||
| "properties": { | ||
| "shareName": "testfileshare", | ||
| "hostName": "fs-vlp5bkznznf0dkb4z.z16.file.storage.azure.net", | ||
| "tier": "SSD", | ||
| "redundancy": "Local", | ||
| "protocols": [ | ||
| "NFS" | ||
| ], | ||
| "provisionedStorageGiB": 80013, | ||
| "provisionedIOPerSec": 16293, | ||
| "provisionedThroughputMiBPerSec": 6721016643, | ||
| "includedBurstIOPerSec": 65925, | ||
| "maxBurstIOPerSecCredits": 0, | ||
| "nfsProtocolProperties": { | ||
| "rootSquash": "NoRootSquash" | ||
| }, | ||
| "publicEndpointNetworkRuleSet": { | ||
| "virtualNetworkRules": [ | ||
| { | ||
| "id": "szgchxzvtnnmgmxwrblakajghfxt" | ||
| } | ||
| ] | ||
| }, | ||
| "provisioningState": "Succeeded" | ||
| }, | ||
| "tags": { | ||
| "key3533": "tagValue" | ||
| }, | ||
| "location": "ijgwtizkwlhftlkpisezexdrkrffy", | ||
| "id": "/subscriptions/11111111-2222-3333-4444-555555555555/resourceGroups/rg1Network/providers/Microsoft.FileShares/fileShares/ankushb-pe-fs-01", | ||
| "name": "testfileshare", | ||
| "type": "Microsoft.FileShares/fileShares", | ||
| "systemData": { | ||
| "createdBy": "testuser", | ||
| "createdByType": "User", | ||
| "createdAt": "2025-04-29T23:32:13.130Z", | ||
| "lastModifiedBy": "kjn", | ||
| "lastModifiedByType": "User", | ||
| "lastModifiedAt": "2025-04-29T23:32:13.131Z" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
18 changes: 18 additions & 0 deletions
18
...s/FileShares.Management/examples/2023-01-01-preview/FileShares_Delete_MaximumSet_Gen.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "title": "FileShares_Delete_MaximumSet", | ||
| "operationId": "FileShares_Delete", | ||
| "parameters": { | ||
| "api-version": "2023-01-01-preview", | ||
| "subscriptionId": "44EEA578-10B8-4489-8B60-2F8BA982F1E2", | ||
| "resourceGroupName": "rgfileshares", | ||
| "resourceName": "testfileshare" | ||
| }, | ||
| "responses": { | ||
| "202": { | ||
| "headers": { | ||
| "location": "https://contoso.com/operationstatus" | ||
| } | ||
| }, | ||
| "204": {} | ||
| } | ||
| } |
56 changes: 56 additions & 0 deletions
56
...ares/FileShares.Management/examples/2023-01-01-preview/FileShares_Get_MaximumSet_Gen.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| { | ||
| "title": "FileShares_Get_MaximumSet", | ||
| "operationId": "FileShares_Get", | ||
| "parameters": { | ||
| "api-version": "2023-01-01-preview", | ||
| "subscriptionId": "44EEA578-10B8-4489-8B60-2F8BA982F1E2", | ||
| "resourceGroupName": "rgfileshares", | ||
| "resourceName": "testfileshare" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "properties": { | ||
| "shareName": "testfileshare", | ||
| "hostName": "fs-vlp5bkznznf0dkb4z.z16.file.storage.azure.net", | ||
| "tier": "SSD", | ||
| "redundancy": "Local", | ||
| "protocols": [ | ||
| "NFS" | ||
| ], | ||
| "provisionedStorageGiB": 80013, | ||
| "provisionedIOPerSec": 16293, | ||
| "provisionedThroughputMiBPerSec": 6721016643, | ||
| "includedBurstIOPerSec": 65925, | ||
| "maxBurstIOPerSecCredits": 0, | ||
| "nfsProtocolProperties": { | ||
| "rootSquash": "NoRootSquash" | ||
| }, | ||
| "publicEndpointNetworkRuleSet": { | ||
| "virtualNetworkRules": [ | ||
| { | ||
| "id": "szgchxzvtnnmgmxwrblakajghfxt" | ||
| } | ||
| ] | ||
| }, | ||
| "provisioningState": "Succeeded" | ||
| }, | ||
| "tags": { | ||
| "key3533": "tagValue" | ||
| }, | ||
| "location": "ijgwtizkwlhftlkpisezexdrkrffy", | ||
| "id": "/subscriptions/11111111-2222-3333-4444-555555555555/resourceGroups/rg1Network/providers/Microsoft.FileShares/fileShares/testfileshare", | ||
| "name": "testfileshare", | ||
| "type": "Microsoft.FileShares/fileShares", | ||
| "systemData": { | ||
| "createdBy": "testuser", | ||
| "createdByType": "User", | ||
| "createdAt": "2025-04-29T23:32:13.130Z", | ||
| "lastModifiedBy": "kjn", | ||
| "lastModifiedByType": "User", | ||
| "lastModifiedAt": "2025-04-29T23:32:13.131Z" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
60 changes: 60 additions & 0 deletions
60
...Shares.Management/examples/2023-01-01-preview/FileShares_ListByParent_MaximumSet_Gen.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| { | ||
| "title": "FileShares_ListByParent_MaximumSet", | ||
| "operationId": "FileShares_ListByParent", | ||
| "parameters": { | ||
| "api-version": "2023-01-01-preview", | ||
| "subscriptionId": "44EEA578-10B8-4489-8B60-2F8BA982F1E2", | ||
| "resourceGroupName": "rgfileshares" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "properties": { | ||
| "shareName": "testfileshare", | ||
| "hostName": "fs-vlp5bkznznf0dkb4z.z16.file.storage.azure.net", | ||
| "tier": "SSD", | ||
| "redundancy": "Local", | ||
| "protocols": [ | ||
| "NFS" | ||
| ], | ||
| "provisionedStorageGiB": 80013, | ||
| "provisionedIOPerSec": 16293, | ||
| "provisionedThroughputMiBPerSec": 6721016643, | ||
| "includedBurstIOPerSec": 65925, | ||
| "maxBurstIOPerSecCredits": 0, | ||
| "nfsProtocolProperties": { | ||
| "rootSquash": "NoRootSquash" | ||
| }, | ||
| "publicEndpointNetworkRuleSet": { | ||
| "virtualNetworkRules": [ | ||
| { | ||
| "id": "szgchxzvtnnmgmxwrblakajghfxt" | ||
| } | ||
| ] | ||
| }, | ||
| "provisioningState": "Succeeded" | ||
| }, | ||
| "tags": { | ||
| "key3533": "tagValue" | ||
| }, | ||
| "location": "ijgwtizkwlhftlkpisezexdrkrffy", | ||
| "id": "/subscriptions/11111111-2222-3333-4444-555555555555/resourceGroups/rg1Network/providers/Microsoft.FileShares/fileShares/ankushb-pe-fs-01", | ||
| "name": "testfileshare", | ||
| "type": "Microsoft.FileShares/fileShares", | ||
| "systemData": { | ||
| "createdBy": "testuser", | ||
| "createdByType": "User", | ||
| "createdAt": "2025-04-29T23:32:13.130Z", | ||
| "lastModifiedBy": "kjn", | ||
| "lastModifiedByType": "User", | ||
| "lastModifiedAt": "2025-04-29T23:32:13.131Z" | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "https://microsoft.com/avr" | ||
| } | ||
| } | ||
| } | ||
| } |
59 changes: 59 additions & 0 deletions
59
....Management/examples/2023-01-01-preview/FileShares_ListBySubscription_MaximumSet_Gen.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| { | ||
| "title": "FileShares_ListBySubscription_MaximumSet", | ||
| "operationId": "FileShares_ListBySubscription", | ||
| "parameters": { | ||
| "api-version": "2023-01-01-preview", | ||
| "subscriptionId": "44EEA578-10B8-4489-8B60-2F8BA982F1E2" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "properties": { | ||
| "shareName": "testfileshare", | ||
| "hostName": "fs-vlp5bkznznf0dkb4z.z16.file.storage.azure.net", | ||
| "tier": "SSD", | ||
| "redundancy": "Local", | ||
| "protocols": [ | ||
| "NFS" | ||
| ], | ||
| "provisionedStorageGiB": 80013, | ||
| "provisionedIOPerSec": 16293, | ||
| "provisionedThroughputMiBPerSec": 6721016643, | ||
| "includedBurstIOPerSec": 65925, | ||
| "maxBurstIOPerSecCredits": 0, | ||
| "nfsProtocolProperties": { | ||
| "rootSquash": "NoRootSquash" | ||
| }, | ||
| "publicEndpointNetworkRuleSet": { | ||
| "virtualNetworkRules": [ | ||
| { | ||
| "id": "szgchxzvtnnmgmxwrblakajghfxt" | ||
| } | ||
| ] | ||
| }, | ||
| "provisioningState": "Succeeded" | ||
| }, | ||
| "tags": { | ||
| "key3533": "tagValue" | ||
| }, | ||
| "location": "ijgwtizkwlhftlkpisezexdrkrffy", | ||
| "id": "/subscriptions/11111111-2222-3333-4444-555555555555/resourceGroups/rg1Network/providers/Microsoft.FileShares/fileShares/ankushb-pe-fs-01", | ||
| "name": "testfileshare", | ||
| "type": "Microsoft.FileShares/fileShares", | ||
| "systemData": { | ||
| "createdBy": "testuser", | ||
| "createdByType": "User", | ||
| "createdAt": "2025-04-29T23:32:13.130Z", | ||
| "lastModifiedBy": "kjn", | ||
| "lastModifiedByType": "User", | ||
| "lastModifiedAt": "2025-04-29T23:32:13.131Z" | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "https://microsoft.com/avr" | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be renamed to OperationInfo