-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[DNM] Validate typespec-azure#2607 #34659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main question for the instances where @identifiers(#[])
was needed, is about what the json looks like before we added this? Was a diagnostic warning emitted, or were some identifiers values that seemed incorrect emitted?
@@ -629,6 +629,7 @@ model AdditionalCacheNodeProperties { | |||
|
|||
#suppress "@azure-tools/typespec-azure-resource-manager/missing-x-ms-identifiers" "" | |||
@doc("Cache node resource drive configurations.") | |||
@Azure.ResourceManager.identifiers(#[]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the behavior without this addition?
@@ -4747,3 +4747,7 @@ model UpdateStatusProperty { | |||
*/ | |||
model ResourceProviderOperationListResult | |||
is Azure.Core.Page<ResourceProviderOperation>; | |||
|
|||
@@Azure.ResourceManager.identifiers(ResourceProviderOperationListResult.value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the behavior without this?
@@ -508,3 +508,5 @@ union FaultSimulationStatus { | |||
*/ | |||
StopFailed: "StopFailed", | |||
} | |||
|
|||
@@Azure.ResourceManager.identifiers(OperationListResult.value, #[]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some question (and for the previous)
/azp run |
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.