[ContainerInstance] Fix TypeSpec validation: correct property name in source example file#42820
Open
MicroJamesLim wants to merge 49 commits into
Open
[ContainerInstance] Fix TypeSpec validation: correct property name in source example file#42820MicroJamesLim wants to merge 49 commits into
MicroJamesLim wants to merge 49 commits into
Conversation
Co-authored-by: Copilot <copilot@github.com>
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
Contributor
|
please address lintdiff, model validation, prettier and typespec validation errors. |
…5-01 Agent-Logs-Url: https://github.com/Azure/azure-rest-api-specs/sessions/ffa3fdcc-3d4c-4df4-ba0b-85b8b955dba0 Co-authored-by: MicroJamesLim <125409279+MicroJamesLim@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Azure/azure-rest-api-specs/sessions/ffa3fdcc-3d4c-4df4-ba0b-85b8b955dba0 Co-authored-by: MicroJamesLim <125409279+MicroJamesLim@users.noreply.github.com>
…gState type definition in containerInstance.json Co-authored-by: MicroJamesLim <125409279+MicroJamesLim@users.noreply.github.com>
Copilot
AI
changed the title
[ContainerInstance] Fix Swagger LintDiff failure for 2026-07-01 by adding missing x-ms-pageable
[containerinstance] Fix TypeSpec validation: remove readOnly from SandboxGroupProvisioningState type definition
Jun 10, 2026
…b.com/Azure/azure-rest-api-specs into user/jameslim/aci-azmi-api-2026-05-01
Co-authored-by: MicroJamesLim <125409279+MicroJamesLim@users.noreply.github.com>
Copilot
AI
changed the title
[containerinstance] Fix TypeSpec validation: remove readOnly from SandboxGroupProvisioningState type definition
[containerinstance] Fix Swagger LintDiff - Analyze Code for 2026-07-01
Jun 11, 2026
…edIdentityClientId in example Co-authored-by: MicroJamesLim <125409279+MicroJamesLim@users.noreply.github.com>
Copilot
AI
changed the title
[containerinstance] Fix Swagger LintDiff - Analyze Code for 2026-07-01
[ContainerInstance] Fix ModelValidation: correct userManagedIdentityClientId to userAssignedIdentityClientId in 2026-07-01 example
Jun 12, 2026
…ntityClientId Co-authored-by: MicroJamesLim <125409279+MicroJamesLim@users.noreply.github.com>
Copilot
AI
changed the title
[ContainerInstance] Fix ModelValidation: correct userManagedIdentityClientId to userAssignedIdentityClientId in 2026-07-01 example
[ContainerInstance] Fix TypeSpec validation: correct property name in source example file
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
This PR fixes the failing TypeSpec Validation CI job for the ContainerInstance
2026-07-01stable API version.Root cause: The TypeSpec source example file
examples/2026-07-01/ContainerGroupsCreateOrUpdateManagedIdentityAzureFileshare.jsonused the property nameuserManagedIdentityClientId, while the TypeSpec model (models.tsp) and the generated swagger definition (containerInstance.json) define the property asuserAssignedIdentityClientId. Whentsp compileran in CI, it copied the source example value (userManagedIdentityClientId) into the generated output file, producing a diff against the committed file and triggering the "files have been changed aftertsp compile" validation failure.Fix: Updated the source example file to use
userAssignedIdentityClientId(matching the TypeSpec model property name and the swagger definition), sotsp compilenow generates output consistent with the committed file — no diff, no failure.Files changed:
specification/containerinstance/resource-manager/Microsoft.ContainerInstance/ContainerInstance/examples/2026-07-01/ContainerGroupsCreateOrUpdateManagedIdentityAzureFileshare.json— replaceduserManagedIdentityClientIdwithuserAssignedIdentityClientId(3 occurrences)Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.