-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[ContainerInstance] Fix TypeSpec validation: correct property name in source example file #42820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MicroJamesLim
wants to merge
49
commits into
main
Choose a base branch
from
user/jameslim/aci-azmi-api-2026-05-01
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
a28bff4
New API version 2026-05-01 for Managed Identity Azure File Share
jamezlim 229f38b
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim 074e21c
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim f71a068
lint and prettier
jamezlim 033e06a
Merge branch 'user/jameslim/aci-azmi-api-2026-05-01' of https://githu…
jamezlim 5adf7a9
run prettier for all examples
jamezlim 32707a0
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim eaecc95
fix(containerinstance): align TypeSpec and generated files for 2026-0…
Copilot bc97ef2
fix(containerinstance): correct OperationsList example typo
Copilot 25026ec
updated model.tsp and main.tsp
jamezlim 17c9a3b
Merge branch 'user/jameslim/aci-azmi-api-2026-05-01' of https://githu…
jamezlim b9f26b3
remove duplicate version
jamezlim d57c0c1
include Ngroups
jamezlim 5127a65
update versions in example files
jamezlim 1b49c3b
tsp compile
jamezlim db1a8c0
change from 2026-05-01 to 2026-07-01
jamezlim 68abc9c
remove userManagedIdentityClientId from 2026-06-01-preview
jamezlim 89848e2
removed sandboxGroups from stable versions
jamezlim d281ec2
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim 0e675a3
Merge branch 'user/jameslim/aci-azmi-api-2026-05-01' of https://githu…
jamezlim 7ef767b
tsp format
jamezlim 2da0775
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim 02c4c6f
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim ebfe2a3
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim 66b2440
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim 28e2039
reactivate sandbox
jamezlim 12f4791
Merge branch 'user/jameslim/aci-azmi-api-2026-05-01' of https://githu…
jamezlim 5ecfc26
tsp compile
jamezlim bfefc33
Add x-ms-pageable to outbound network dependencies GET
Copilot e806709
updated with sandbox examples
jamezlim feb3b8d
Merge branch 'user/jameslim/aci-azmi-api-2026-05-01' of https://githu…
jamezlim 9e27472
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim 909b14c
tsp compile
jamezlim 6557788
Merge branch 'user/jameslim/aci-azmi-api-2026-05-01' of https://githu…
jamezlim 8bdd282
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim ba3580e
set to read only
jamezlim b492165
Merge branch 'user/jameslim/aci-azmi-api-2026-05-01' of https://githu…
jamezlim 2c65fd8
Fix TypeSpec validation: remove readOnly from SandboxGroupProvisionin…
Copilot f3fd392
tsp compile
jamezlim 2c24c1d
Merge branch 'user/jameslim/aci-azmi-api-2026-05-01' of https://githu…
jamezlim 44453bc
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim 971d697
Add ContainerInstance 2026-07-01 LintDiff suppressions
Copilot 7ce9253
Fix ModelValidation: rename userManagedIdentityClientId to userAssign…
Copilot 7221cac
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim 28895ae
Fix TypeSpec validation: update source example to use userAssignedIde…
Copilot fdcb796
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim c27f9f9
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim 11e1549
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim 8838953
Merge branch 'main' into user/jameslim/aci-azmi-api-2026-05-01
MicroJamesLim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
29 changes: 29 additions & 0 deletions
29
...r/Microsoft.ContainerInstance/ContainerInstance/examples/2026-07-01/CachedImagesList.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2026-07-01", | ||
| "location": "westcentralus", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "image": "ubuntu:16.04", | ||
| "osType": "Linux" | ||
| }, | ||
| { | ||
| "image": "alpine:3.6", | ||
| "osType": "Linux" | ||
| }, | ||
| { | ||
| "image": "microsoft/nanoserver:10.0.14393.2485", | ||
| "osType": "Windows" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "operationId": "Location_ListCachedImages", | ||
| "title": "CachedImages" | ||
| } |
41 changes: 41 additions & 0 deletions
41
...r/Microsoft.ContainerInstance/ContainerInstance/examples/2026-07-01/CapabilitiesList.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2026-07-01", | ||
| "location": "westus", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "capabilities": { | ||
| "maxCpu": 4, | ||
| "maxGpuCount": 4, | ||
| "maxMemoryInGB": 14 | ||
| }, | ||
| "gpu": "K80", | ||
| "ipAddressType": "Public", | ||
| "location": "West US", | ||
| "osType": "Linux", | ||
| "resourceType": "containerGroups" | ||
| }, | ||
| { | ||
| "capabilities": { | ||
| "maxCpu": 4, | ||
| "maxGpuCount": 0, | ||
| "maxMemoryInGB": 14 | ||
| }, | ||
| "gpu": "None", | ||
| "ipAddressType": "Public", | ||
| "location": "West US", | ||
| "osType": "Windows", | ||
| "resourceType": "containerGroups" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "operationId": "Location_ListCapabilities", | ||
| "title": "GetCapabilities" | ||
| } |
19 changes: 19 additions & 0 deletions
19
...er/Microsoft.ContainerInstance/ContainerInstance/examples/2026-07-01/ContainerAttach.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2026-07-01", | ||
| "containerGroupName": "demo1", | ||
| "containerName": "container1", | ||
| "resourceGroupName": "demo", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "password": "password", | ||
| "webSocketUri": "wss://web-socket-uri" | ||
| } | ||
| } | ||
| }, | ||
| "operationId": "Containers_Attach", | ||
| "title": "ContainerAttach" | ||
| } | ||
26 changes: 26 additions & 0 deletions
26
...ager/Microsoft.ContainerInstance/ContainerInstance/examples/2026-07-01/ContainerExec.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2026-07-01", | ||
| "containerExecRequest": { | ||
| "command": "/bin/bash", | ||
| "terminalSize": { | ||
| "cols": 12, | ||
| "rows": 12 | ||
| } | ||
| }, | ||
| "containerGroupName": "demo1", | ||
| "containerName": "container1", | ||
| "resourceGroupName": "demo", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "password": "password", | ||
| "webSocketUri": "wss://web-socket-uri" | ||
| } | ||
|
Comment on lines
+18
to
+21
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Re-checked on latest commit 28895ae: still unresolved. ContainerExec.json response still includes "password": "password". Please use a non-secret placeholder such as "********" or "{password}". |
||
| } | ||
| }, | ||
| "operationId": "Containers_ExecuteCommand", | ||
| "title": "ContainerExec" | ||
| } | ||
186 changes: 186 additions & 0 deletions
186
...ainerInstance/ContainerInstance/examples/2026-07-01/ContainerGroupCreateConfidential.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,186 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2026-07-01", | ||
| "containerGroup": { | ||
| "location": "westeurope", | ||
| "properties": { | ||
| "confidentialComputeProperties": { | ||
| "ccePolicy": "eyJhbGxvd19hbGwiOiB0cnVlLCAiY29udGFpbmVycyI6IHsibGVuZ3RoIjogMCwgImVsZW1lbnRzIjogbnVsbH19" | ||
| }, | ||
| "containers": [ | ||
| { | ||
| "name": "accdemo", | ||
| "properties": { | ||
| "command": [], | ||
| "environmentVariables": [], | ||
| "image": "confiimage", | ||
| "ports": [ | ||
| { | ||
| "port": 8000 | ||
| } | ||
| ], | ||
| "resources": { | ||
| "requests": { | ||
| "cpu": 1, | ||
| "memoryInGB": 1.5 | ||
| } | ||
| }, | ||
| "securityContext": { | ||
| "capabilities": { | ||
| "add": [ | ||
| "CAP_NET_ADMIN" | ||
| ] | ||
| }, | ||
| "privileged": false | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "imageRegistryCredentials": [], | ||
| "ipAddress": { | ||
| "type": "Public", | ||
| "ports": [ | ||
| { | ||
| "port": 8000, | ||
| "protocol": "TCP" | ||
| } | ||
| ] | ||
| }, | ||
| "osType": "Linux", | ||
| "sku": "Confidential" | ||
| } | ||
| }, | ||
| "containerGroupName": "demo1", | ||
| "resourceGroupName": "demo", | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "zones": [ | ||
| "1" | ||
| ] | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "name": "demo1", | ||
| "type": "Microsoft.ContainerInstance/containerGroups", | ||
| "id": "/subscriptions/00000000-0000-0000-0000-00000000/resourceGroups/test-rg/providers/Microsoft.ContainerInstance/containerGroups/demo1", | ||
| "location": "westeurope", | ||
| "properties": { | ||
| "confidentialComputeProperties": { | ||
| "ccePolicy": "eyJhbGxvd19hbGwiOiB0cnVlLCAiY29udGFpbmVycyI6IHsibGVuZ3RoIjogMCwgImVsZW1lbnRzIjogbnVsbH19" | ||
| }, | ||
| "containers": [ | ||
| { | ||
| "name": "accdemo", | ||
| "properties": { | ||
| "command": [], | ||
| "environmentVariables": [], | ||
| "image": "confiimage", | ||
| "ports": [ | ||
| { | ||
| "port": 8000 | ||
| } | ||
| ], | ||
| "resources": { | ||
| "requests": { | ||
| "cpu": 1, | ||
| "memoryInGB": 1.5 | ||
| } | ||
| }, | ||
| "securityContext": { | ||
| "capabilities": { | ||
| "add": [ | ||
| "CAP_NET_ADMIN" | ||
| ] | ||
| }, | ||
| "privileged": false | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "imageRegistryCredentials": [], | ||
| "initContainers": [], | ||
| "instanceView": { | ||
| "events": [], | ||
| "state": "Running" | ||
| }, | ||
| "ipAddress": { | ||
| "type": "Public", | ||
| "ports": [ | ||
| { | ||
| "port": 8000, | ||
| "protocol": "TCP" | ||
| } | ||
| ] | ||
| }, | ||
| "isCreatedFromStandbyPool": false, | ||
| "osType": "Linux", | ||
| "provisioningState": "Succeeded", | ||
| "sku": "Confidential" | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "name": "demo1", | ||
| "type": "Microsoft.ContainerInstance/containerGroups", | ||
| "id": "/subscriptions/00000000-0000-0000-0000-00000000/resourceGroups/test-rg/providers/Microsoft.ContainerInstance/containerGroups/demo1", | ||
| "location": "westeurope", | ||
| "properties": { | ||
| "confidentialComputeProperties": { | ||
| "ccePolicy": "eyJhbGxvd19hbGwiOiB0cnVlLCAiY29udGFpbmVycyI6IHsibGVuZ3RoIjogMCwgImVsZW1lbnRzIjogbnVsbH19" | ||
| }, | ||
| "containers": [ | ||
| { | ||
| "name": "accdemo", | ||
| "properties": { | ||
| "command": [], | ||
| "environmentVariables": [], | ||
| "image": "confiimage", | ||
| "ports": [ | ||
| { | ||
| "port": 8000 | ||
| } | ||
| ], | ||
| "resources": { | ||
| "requests": { | ||
| "cpu": 1, | ||
| "memoryInGB": 1.5 | ||
| } | ||
| }, | ||
| "securityContext": { | ||
| "capabilities": { | ||
| "add": [ | ||
| "CAP_NET_ADMIN" | ||
| ] | ||
| }, | ||
| "privileged": false | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "imageRegistryCredentials": [], | ||
| "initContainers": [], | ||
| "instanceView": { | ||
| "events": [], | ||
| "state": "Running" | ||
| }, | ||
| "ipAddress": { | ||
| "type": "Public", | ||
| "ports": [ | ||
| { | ||
| "port": 8000, | ||
| "protocol": "TCP" | ||
| } | ||
| ] | ||
| }, | ||
| "isCreatedFromStandbyPool": false, | ||
| "osType": "Linux", | ||
| "provisioningState": "Succeeded", | ||
| "sku": "Confidential" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "operationId": "ContainerGroups_CreateOrUpdate", | ||
| "title": "ConfidentialContainerGroup" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-checked on latest commit 28895ae: still unresolved. ContainerAttach.json response still includes "password": "password". Please replace with a non-secret placeholder.