Skip to content

Add API version 2026-06-15-preview and resource type UpgradeAssessments in KubernetesConfiguration RP#43934

Open
bgriddaluru wants to merge 26 commits into
Azure:mainfrom
bgriddaluru:upgradeAssessment
Open

Add API version 2026-06-15-preview and resource type UpgradeAssessments in KubernetesConfiguration RP#43934
bgriddaluru wants to merge 26 commits into
Azure:mainfrom
bgriddaluru:upgradeAssessment

Conversation

@bgriddaluru

@bgriddaluru bgriddaluru commented Jun 12, 2026

Copy link
Copy Markdown
Member

Add API version 2026-06-15-preview and resource type UpgradeAssessments in KubernetesConfiguration RP

Overview

This PR adds support for the Kubernetes upgrade assessment feature in Kubernetes Configuration RP.

  1. An in-cluster agent gathers inventory and metrics from the Kubernetes API server and generates an upgrade assessment report.
  2. The report highlights Kubernetes components that may fail or become incompatible after a Kubernetes upgrade.
  3. The in-cluster agent sends the report to Kubernetes Configuration RP, which publishes it to ARG through ARN.
  4. Users can view the report in the Azure portal or query it directly from ARG.

Notes

  1. UpgradeAssessment is a read-only resource. So the provisioningState field is intentionally omitted.

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review


Comment generated by summarize-checks workflow run.

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

@bgriddaluru bgriddaluru added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jun 17, 2026
@github-actions github-actions Bot added ARMModelingAutoSignedOff WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMModelingReviewRequired NotReadyForARMReview labels Jun 26, 2026

@ravimeda ravimeda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM API Review

Posting findings from the ARM API Reviewer agent (critic-verified, 1 iteration, converged) against commit 796a423. See inline comments for findings 1-4.

@ravimeda ravimeda added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 26, 2026
@github-actions github-actions Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 29, 2026
@psah434

psah434 commented Jul 6, 2026

Copy link
Copy Markdown
Member

[NEW] 🟠 Warning — cross-file consistency + correctness — UpgradeAssessment.tsp line 52 (@pattern), doc lines 46-47

The clusterRp path-parameter allowlist pattern ^Microsoft\.(ContainerService|Kubernetes|HybridContainerService|KubernetesConfiguration)$ and its description include Microsoft.KubernetesConfiguration as a valid Kubernetes cluster RP. Microsoft.KubernetesConfiguration is the extension RP itself and hosts no Kubernetes clusters. The sibling operations/preview/2026-06-15-preview/operations.json (line 106) lists only Microsoft.ContainerService, Microsoft.Kubernetes, Microsoft.HybridContainerService. This is an intra-RP inconsistency and a likely copy artifact.

Classification reasoning: [NEW] — this resource and its clusterRp parameter are introduced in this PR; no previous version exists.

Suggested fix: Remove KubernetesConfiguration from the @pattern and the description unless there is a concrete scenario where an upgrade assessment targets a cluster hosted by Microsoft.KubernetesConfiguration. Please confirm the intended cluster-RP set.

@psah434

psah434 commented Jul 6, 2026

Copy link
Copy Markdown
Member

[NEW] 🔵 Suggestion — description accuracy — models.tsp line 151

ReadinessCheck.details doc says "Human-readable reason when severity is not 'pass'." but the Severity enum is None | Warning | Critical | Unknown — there is no pass value. A reviewer previously flagged severity = pass in the example (now corrected to None), but this description text still references the nonexistent value.

Classification reasoning: [NEW] — introduced in this PR.

Suggested fix: Reword, e.g. "Human-readable reason when severity is not 'None'."

@psah434 psah434 added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 6, 2026
@bgriddaluru bgriddaluru closed this Jul 6, 2026
@bgriddaluru bgriddaluru reopened this Jul 6, 2026
@bgriddaluru

Copy link
Copy Markdown
Member Author

Fixed review comments in latest patch

@github-actions github-actions Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Suppression ARMModelingAutoSignedOff ARMReview new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager SuppressionReviewRequired TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants