Use HttpResponseException in annotation-processor #45053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samvaity
force-pushed
the
exception-update
branch
from
a6551c7 to
af2ee68
Compare
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
samvaity
force-pushed
the
exception-update
branch
from
af2ee68 to
aea6d50
Compare
samvaity
commented
Apr 23, 2025
.../src/main/java/io/clientcore/annotation/processor/test/SimpleXmlSerializableServiceImpl.java
Outdated
Show resolved
Hide resolved
samvaity
force-pushed
the
exception-update
branch
2 times, most recently
from
f401cea to
ea9e072
Compare
samvaity
commented
Apr 29, 2025
...test/src/main/java/io/clientcore/annotation/processor/test/ParameterizedHostServiceImpl.java
Outdated
Show resolved
Hide resolved
samvaity
force-pushed
the
exception-update
branch
2 times, most recently
from
c81501f to
621b47a
Compare
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
...sor-test/src/main/java/io/clientcore/annotation/processor/test/HostEdgeCase1ServiceImpl.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/utils/CoreUtils.java
Outdated
Show resolved
Hide resolved
sdk/clientcore/core/src/main/java/io/clientcore/core/utils/CoreUtils.java
Outdated
Show resolved
Hide resolved
.../main/java/io/clientcore/annotation/processor/test/ParameterizedMultipleHostServiceImpl.java
Outdated
Show resolved
Hide resolved
.../java/io/clientcore/annotation/processor/test/TestInterfaceServiceClientGenerationTests.java
Outdated
Show resolved
Hide resolved
...ain/java/io/clientcore/annotation/processor/test/implementation/TestInterfaceClientImpl.java
Show resolved
Hide resolved
...tation-processor/src/main/java/io/clientcore/annotation/processor/utils/ResponseHandler.java
Outdated
Show resolved
Hide resolved
samvaity
force-pushed
the
exception-update
branch
from
4e30b29 to
6ac6f83
Compare
samvaity
force-pushed
the
exception-update
branch
from
831d5a7 to
d82f8d1
Compare
...sor-test/src/main/java/io/clientcore/annotation/processor/test/HostEdgeCase1ServiceImpl.java
Outdated
Show resolved
Hide resolved
...a/io/clientcore/annotation/processor/test/implementation/TestInterfaceClientServiceImpl.java
Outdated
Show resolved
Hide resolved
alzimmermsft
approved these changes
May 22, 2025
samvaity
force-pushed
the
exception-update
branch
from
5952c48 to
34650ff
Compare
alzimmermsft
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #43728
Summary of patterns for status code + exception Mapping handling:
defaultErrorBodyType = ...; ...handleUnexpectedResponse(..., defaultErrorBodyType, null);statusToExceptionTypeMap = ...; ...handleUnexpectedResponse(..., null, statusToExceptionTypeMap);statusToExceptionTypeMap = ...; defaultErrorBodyType = ...; ...handleUnexpectedResponse(..., defaultErrorBodyType, statusToExceptionTypeMap);...handleUnexpectedResponse(..., null, null);