-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Triggering Paths #33395
Open
scbedd
wants to merge
3
commits into
main
Choose a base branch
from
update-triggering-paths
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update Triggering Paths #33395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CI configuration files to simplify artifact triggering by standardizing the triggeringPaths across multiple services.
- Added or updated triggeringPaths entries in CI YAML files for services including servicebus, resources, identity, template, core, textanalytics, eventgrid, and storage.
- Ensured that core package artifacts only trigger on changes to /common/config/ while other services use paths more broadly associated with their respective contexts.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
sdk/servicebus/ci.yml | Added triggeringPaths entries to monitor configuration and related directories. |
sdk/resources/ci.mgmt.yml | Introduced triggeringPaths for multiple artifact builds. |
sdk/identity/ci.yml | Added triggeringPaths for various artifacts including identity and cache persistence. |
sdk/template/ci.yml | Updated triggeringPaths to reflect new dependency monitoring. |
sdk/core/ci.yml | Configured triggeringPaths for core artifacts to use /common/config/. |
sdk/textanalytics/ci.yml | Added triggeringPaths to include test-utils and identity directories. |
sdk/eventgrid/ci.mgmt.yml | Added triggeringPaths to monitor changes in test-utils. |
sdk/storage/ci.yml | Added triggeringPaths for azure-storage-blob artifact. |
jeremymeng
reviewed
Mar 14, 2025
Co-authored-by: Jeremy Meng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure.Core
Azure.Identity
Cognitive - Text Analytics
EngSys
This issue is impacting the engineering system.
Mgmt
This issue is related to a management-plane library.
Service Bus
Storage
Storage Service (Queues, Blobs, Files)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jeremymeng this should be directly equivalent to the more complicated
Language-Settings
function pieces. Our common PR process has evolved a bit since we integrated JS intopullrequest
, so we have a bit more flexibility now.Even with that, I can't trigger an artifact on a non-direct path if said artifact doesn't belong to a CI.yml, so I can't do anything with the storage-perf tests package that is still being added in the custom
Language-Settings
function. If it existed in an artifact (or if my common code honored a different way to define the dependency), I could entirely eliminate the customadditionalpackagesforvalidation
function in this repo.The inciting question for this PR is encapsulated in the changes to
core/ci.yml
. Changes tocommon/config
triggers every single core package indirectly now. We can tune that down if you want Jeremy.This is the general logic of the original AdditionalValidationPackages function, and what is now handled by the addition of
triggeringPaths
: