Update Triggering Paths

eng/scripts/Language-Settings.ps1

@@ -7,9 +7,8 @@ $MetadataUri = "https://raw.githubusercontent.com/Azure/azure-sdk/main/_data/rel
 $GithubUri = "https://github.com/Azure/azure-sdk-for-js"
 $PackageRepositoryUri = "https://www.npmjs.com/package"
 $ReducedDependencyLookup = @{
-  'core'       = @('@azure-rest/synapse-access-control', '@azure/arm-resources', '@azure/identity', '@azure/service-bus', '@azure/template')
-  'test-utils' = @('@azure-tests/perf-storage-blob', '@azure/arm-eventgrid', '@azure/ai-text-analytics', '@azure/identity', '@azure/template')
-  'identity'   = @('@azure-tests/perf-storage-blob', '@azure/ai-text-analytics', '@azure/arm-resources', '@azure/identity-cache-persistence', '@azure/identity-vscode', '@azure/storage-blob', '@azure/template')
+  'test-utils' = @('@azure-tests/perf-storage-blob')
+  'identity'   = @('@azure-tests/perf-storage-blob')
 }
 
 . "$PSScriptRoot/docs/Docs-ToC.ps1"
@@ -39,75 +38,26 @@ function Get-javascript-AdditionalValidationPackagesFromPackageSet {
     [Parameter(Mandatory = $true)]
     $AllPkgProps
   )
-  $additionalValidationPackages = @()
-
-  function isOther($fileName) {
-    $startsWithPrefixes = @(".config", ".devcontainer", ".github", ".scripts", ".vscode", "common", "design", "documentation", "eng", "samples")
-
-    foreach ($prefix in $startsWithPrefixes) {
-      if ($fileName.StartsWith($prefix)) {
-        return $true
-      }
-    }
-
-    return $false
-  }
-
-  $targetedFiles = $diffObj.ChangedFiles
-  if ($diff.DeletedFiles) {
-    if (-not $targetedFiles) {
-      $targetedFiles = @()
-    }
-    $targetedFiles += $diff.DeletedFiles
-  }
-
-  # The targetedFiles needs to filter out anything in the ExcludePaths
-  # otherwise it'll end up processing things below that it shouldn't be.
-  foreach ($excludePath in $diffObj.ExcludePaths) {
-    $targetedFiles = $targetedFiles | Where-Object { -not $_.StartsWith($excludePath) }
-  }
-
-  $changedServices = @()
-  foreach ($file in $targetedFiles) {
-    $pathComponents = $file -split "/"
-    # handle changes only in sdk/<service>/<file>/<extension>
-    if ($pathComponents.Length -eq 3 -and $pathComponents[0] -eq "sdk") {
-      $changedServices += $pathComponents[1]
-    }
-
-    # handle any changes under sdk/<file>.<extension> or in the root of
-    # the repository
-    if (($pathComponents.Length -eq 2 -and $pathComponents[0] -eq "sdk") -or
-        ($pathComponents.Length -eq 1)) {
-      $changedServices += "template"
-    }
-  }
-  $othersChanged = @()
-
-  if ($targetedFiles) {
-    $othersChanged = $targetedFiles | Where-Object { isOther $_ }
-  }
-  $changedServices = $changedServices | Get-Unique
-
-  if ($othersChanged) {
-    $additionalPackages = $ReducedDependencyLookup["core"] | ForEach-Object { $me = $_; $AllPkgProps | Where-Object { $_.Name -eq $me } | Select-Object -First 1 }
-    $additionalValidationPackages += $additionalPackages
-  }
+  $existingPackages = $LocatedPackages | ForEach-Object { $_.Name }
+  $additionalDetectedPackages = @()
+  $uniqueResultSet = @()
 
+  # we don't currently have a way to trigger a package that doesn't exist in an artifact set
+  # so we can't trigger @azure-tests/perf-storage-blob based on changes to sdk/test-utils/ using any common tooling
+  # for now we will handle this in this function.
   foreach ($changedService in $changedServices) {
     if ($ReducedDependencyLookup.ContainsKey($changedService)) {
-      $additionalPackages = $ReducedDependencyLookup[$changedService] | ForEach-Object { $me = $_; $AllPkgProps | Where-Object { $_.Name -eq $me } | Select-Object -First 1 }
-      $additionalValidationPackages += $additionalPackages
-    }
-    else {
-      $additionalPackages = $AllPkgProps | Where-Object { $_.ServiceDirectory -eq $changedService }
-      $additionalValidationPackages += $additionalPackages
+      $additionalPackages = $ReducedDependencyLookup[$changedService] `
+      | ForEach-Object { $me = $_; $AllPkgProps | Where-Object { $_.Name -eq $me } | Select-Object -First 1 }
+
+      # we don't need to worry about duplicates here, we'll handle that later
+      $additionalDetectedPackages += $additionalPackages
     }
   }
 
-  $uniqueResultSet = @()
-  foreach ($pkg in $additionalValidationPackages) {
-    if ($uniqueResultSet -notcontains $pkg -and $LocatedPackages -notcontains $pkg) {
+  foreach ($pkg in $additionalDetectedPackages) {
+    $alreadyIncluded = $uniqueResultSet | ForEach-Object { $_.Name }
+    if ($existingPackages -notcontains $pkg.Name -and $alreadyIncluded -notcontains $pkg.Name) {
       $pkg.IncludedForValidation = $true
       $uniqueResultSet += $pkg
     }

sdk/core/ci.yml

@@ -40,31 +40,61 @@ extends:
     Artifacts:
       - name: azure-abort-controller
         safeName: azureabortcontroller
+        triggeringPaths:
+        - /common/config/
       - name: azure-core-amqp
         safeName: azurecoreamqp
+        triggeringPaths:
+        - /common/config/
       - name: azure-core-auth
         safeName: azurecoreauth
+        triggeringPaths:
+        - /common/config/
       - name: azure-core-client
         safeName: azurecoreclient
+        triggeringPaths:
+        - /common/config/
       - name: azure-rest-core-client
         safeName: azurerestcoreclient
+        triggeringPaths:
+        - /common/config/
       - name: azure-core-rest-pipeline
         safeName: azurecorerestpipeline
+        triggeringPaths:
+        - /common/config/
       - name: azure-core-lro
         safeName: azurecorelro
+        triggeringPaths:
+        - /common/config/
       - name: azure-core-paging
         safeName: azurecorepaging
+        triggeringPaths:
+        - /common/config/
       - name: azure-core-tracing
         safeName: azurecoretracing
+        triggeringPaths:
+        - /common/config/
       - name: azure-core-xml
         safeName: azurecorexml
+        triggeringPaths:
+        - /common/config/
       - name: azure-core-util
         safeName: azurecoreutil
+        triggeringPaths:
+        - /common/config/
       - name: azure-logger
         safeName: azurelogger
+        triggeringPaths:
+        - /common/config/
       - name: azure-core-http-compat
         safeName: azurecorehttpcompat
+        triggeringPaths:
+        - /common/config/
       - name: azure-core-sse
         safeName: azurecoresse
+        triggeringPaths:
+        - /common/config/
       - name: typespec-ts-http-runtime
         safeName: typespectshttpruntime
+        triggeringPaths:
+        - /common/config/

sdk/eventgrid/ci.mgmt.yml

@@ -1,5 +1,5 @@
 # NOTE: Please refer to https://aka.ms/azsdk/engsys/ci-yaml before editing this file.
-                
+
 trigger:
   branches:
     include:
@@ -30,3 +30,5 @@ extends:
     Artifacts:
       - name: azure-arm-eventgrid
         safeName: azurearmeventgrid
+        triggeringPaths:
+        - /sdk/test-utils/

sdk/identity/ci.yml

@@ -28,10 +28,26 @@ extends:
     Artifacts:
       - name: azure-identity
         safeName: azureidentity
+        triggeringPaths:
+        - /sdk/test-utils/
+        - /.config/
+        - /.devcontainer/
+        - /.github/
+        - /.scripts/
+        - /.vscode/
+        - /common/
+        - /design/
+        - /documentation/
+        - /eng/
+        - /samples/
       - name: azure-identity-cache-persistence
         safeName: azureidentitycachepersistence
+        triggeringPaths:
+        - /sdk/identity/
       - name: azure-identity-broker
         safeName: azureidentitybroker
       - name: azure-identity-vscode
         safeName: azureidentityvscode
         skipPublishDocMs: true
+        triggeringPaths:
+        - /sdk/identity/

sdk/resources/ci.mgmt.yml

@@ -1,5 +1,5 @@
 # NOTE: Please refer to https://aka.ms/azsdk/engsys/ci-yaml before editing this file.
-                
+
 trigger:
   branches:
     include:
@@ -32,5 +32,17 @@ extends:
     Artifacts:
       - name: azure-arm-resources
         safeName: azurearmresources
+        triggeringPaths:
+        - /sdk/identity/
+        - /.config/
+        - /.devcontainer/
+        - /.github/
+        - /.scripts/
+        - /.vscode/
+        - /common/
+        - /design/
+        - /documentation/
+        - /eng/
+        - /samples/
       - name: azure-arm-resources-profile-2020-09-01-hybrid
         safeName: azurearmresourcesprofile20200901hybrid

sdk/servicebus/ci.yml

@@ -1,5 +1,5 @@
 # NOTE: Please refer to https://aka.ms/azsdk/engsys/ci-yaml before editing this file.
-                
+
 trigger:
   branches:
     include:
@@ -36,3 +36,14 @@ extends:
     Artifacts:
       - name: azure-service-bus
         safeName: azureservicebus
+        triggeringPaths:
+        - /.config/
+        - /.devcontainer/
+        - /.github/
+        - /.scripts/
+        - /.vscode/
+        - /common/
+        - /design/
+        - /documentation/
+        - /eng/
+        - /samples/

sdk/storage/ci.yml

@@ -1,5 +1,5 @@
 # NOTE: Please refer to https://aka.ms/azsdk/engsys/ci-yaml before editing this file.
-                
+
 trigger:
   branches:
     include:
@@ -38,6 +38,8 @@ extends:
     Artifacts:
       - name: azure-storage-blob
         safeName: azurestorageblob
+        triggeringPaths:
+        - /sdk/identity/
       - name: azure-storage-file-share
         safeName: azurestoragefileshare
       - name: azure-storage-file-datalake

sdk/template/ci.yml

@@ -43,5 +43,18 @@ extends:
     Artifacts:
       - name: azure-template
         safeName: azuretemplate
+        triggeringPaths:
+        - /sdk/test-utils/
+        - /sdk/identity/
+        - /.config/
+        - /.devcontainer/
+        - /.github/
+        - /.scripts/
+        - /.vscode/
+        - /common/
+        - /design/
+        - /documentation/
+        - /eng/
+        - /samples/
       - name: azure-template-dpg
         safeName: azuretemplatedpg

sdk/textanalytics/ci.yml

@@ -28,3 +28,6 @@ extends:
     Artifacts:
       - name: azure-ai-text-analytics
         safeName: azureaitextanalytics
+        triggeringPaths:
+        - /sdk/test-utils/
+        - /sdk/identity/