[monitor-opentelemetry] fix type checking build error #34297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymeng
requested review from
hectorhdzg,
rads-1996,
Karlie-777,
MSNev and
JacksonWeber
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a type checking build error related to recent changes in @types/node by narrowing the type of headers before accessing the user-agent property.
- The headers check now excludes cases where headers is a string array.
- The logic for checking both "User-Agent" and "user-agent" header keys is preserved.
Comments suppressed due to low confidence (1)
sdk/monitor/monitor-opentelemetry/src/utils/common.ts:19
- [nitpick] Consider using the includes() method (e.g., .toString().includes(...)) for substring checking to improve code readability.
.toString().indexOf("azsdk-js-monitor-opentelemetry-exporter") > -1
The latest @types/node changes add `string[]` to the `RequestOptions.headers` type: DefinitelyTyped/DefinitelyTyped#72617 nodejs/node#58049 This PR adds a check and narrow the the type to `http.OutgoingHttpHeaders` before accessing user-agent property. We don't ever set the user agent header using the `string[]` form so this should be fine.
jeremymeng
force-pushed
the
monitor/ot-build-error-may-25
branch
from
761455d to
8e2d876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest @types/node changes add
string[]to theRequestOptions.headerstype:DefinitelyTyped/DefinitelyTyped#72617
nodejs/node#58049
This PR adds a check and narrow the type to
http.OutgoingHttpHeadersbefore accessing user-agentproperty. We don't ever set the user agent header using the
string[]form so this should be fine.