[EventGrid] Incremental source generator #49445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
requested review from
JoshLove-msft,
jsquire and
m-redding
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @danielmarbach! We will review the pull request and get back to you soon. |
|
@JoshLove-msft @jsquire @m-redding @m-nash Another follow up on the previous one |
|
API change check API changes are not detected in this pull request. |
|
@m-nash: As our resident source generator SME, would appreciate your thoughts. |
jsquire
reviewed
Apr 21, 2025
...eventgrid/Azure.Messaging.EventGrid/EventGridSourceGenerator/src/EventGridSourceGenerator.cs
Show resolved
Hide resolved
|
@m-nash: poke |
m-nash
reviewed
Apr 30, 2025
...eventgrid/Azure.Messaging.EventGrid/EventGridSourceGenerator/src/EventGridSourceGenerator.cs
Outdated
Show resolved
Hide resolved
...eventgrid/Azure.Messaging.EventGrid/EventGridSourceGenerator/src/EventGridSourceGenerator.cs
Outdated
Show resolved
Hide resolved
...eventgrid/Azure.Messaging.EventGrid/EventGridSourceGenerator/src/EventGridSourceGenerator.cs
Outdated
Show resolved
Hide resolved
...eventgrid/Azure.Messaging.EventGrid/EventGridSourceGenerator/src/EventGridSourceGenerator.cs
Outdated
Show resolved
Hide resolved
danielmarbach
force-pushed
the
incremental-source-generator
branch
from
92fa514 to
f99c957
Compare
|
@m-nash I think this is done. Wrapping up things for today, but you are welcome to push further adjustments if needed. The PR has edit rights. |
|
Ping @m-nash |
|
Any reviewers? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #49426
These changes will improve build times, particularly for large projects, by only regenerating source when relevant files have changed. The optimized string parsing also reduces memory allocations and improves generator execution speed.