-
Notifications
You must be signed in to change notification settings - Fork 5k
[EventGrid] Incremental source generator #49445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jsquire
merged 11 commits into
Azure:main
from
danielmarbach:incremental-source-generator
May 20, 2025
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
67c71f3
Using a more efficient incremental source generator
danielmarbach 5a3bcd9
Cleanup visitor
danielmarbach 96377e3
Make node immutable
danielmarbach a77cfa4
Indent
danielmarbach c6cc469
The code is self-explanatory
danielmarbach ea35546
Only scan SystemEvents
danielmarbach b217996
Filter duplicates
danielmarbach 36654c6
Remove catch since there is enough validation to not require it
danielmarbach 6fc1b49
Avoid another cast
danielmarbach a9feab1
More straightforward namespace search
danielmarbach f99c957
AppendIndentedLine
danielmarbach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 0 additions & 52 deletions
52
sdk/eventgrid/Azure.Messaging.EventGrid/EventGridSourceGenerator/src/SourceVisitor.cs
This file was deleted.
Oops, something went wrong.
16 changes: 16 additions & 0 deletions
16
...entgrid/Azure.Messaging.EventGrid/EventGridSourceGenerator/src/StringBuilderExtensions.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
|
||
using System.Text; | ||
|
||
namespace Azure.EventGrid.Messaging.SourceGeneration | ||
{ | ||
internal static class StringBuilderExtensions | ||
{ | ||
public static void AppendIndentedLine(this StringBuilder sb, int indentLevel, string text) | ||
{ | ||
sb.Append(' ', indentLevel * 4); | ||
sb.AppendLine(text); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.