Skip to content

Assign default name to QueueService #49672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 16, 2025
Merged

Assign default name to QueueService #49672

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
efabf41
Assign default name to QueueService
kzhen Apr 28, 2025
d65be5e
Updated API for Azure.Provisioning.Storage (via Export-API.ps1)
kzhen Apr 28, 2025
1cb4089
add back the missing api
ArcturusZhang May 8, 2025
15ca1fd
add changelog
ArcturusZhang May 8, 2025
db71655
Merge remote-tracking branch 'origin/main' into fix-queueservice-defa…
ArcturusZhang May 9, 2025
2b8b204
update version to 1.0.1
ArcturusZhang May 9, 2025
32b9aff
Merge remote-tracking branch 'origin/main' into fix-queueservice-defa…
ArcturusZhang May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdk/provisioning/Azure.Provisioning.Storage/api/Azure.Provisioning.Storage.net8.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,6 @@ public partial class QueueService : Azure.Provisioning.Primitives.ProvisionableR
public QueueService(string bicepIdentifier, string? resourceVersion = null) : base (default(string), default(Azure.Core.ResourceType), default(string)) { }
public Azure.Provisioning.BicepList<Azure.Provisioning.Storage.StorageCorsRule> CorsRules { get { throw null; } set { } }
public Azure.Provisioning.BicepValue<Azure.Core.ResourceIdentifier> Id { get { throw null; } }
public Azure.Provisioning.BicepValue<string> Name { get { throw null; } }
public Azure.Provisioning.Storage.StorageAccount? Parent { get { throw null; } set { } }
public Azure.Provisioning.Resources.SystemData SystemData { get { throw null; } }
protected override void DefineProvisionableProperties() { }
Expand Down
1 change: 0 additions & 1 deletion sdk/provisioning/Azure.Provisioning.Storage/api/Azure.Provisioning.Storage.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,6 @@ public partial class QueueService : Azure.Provisioning.Primitives.ProvisionableR
public QueueService(string bicepIdentifier, string? resourceVersion = null) : base (default(string), default(Azure.Core.ResourceType), default(string)) { }
public Azure.Provisioning.BicepList<Azure.Provisioning.Storage.StorageCorsRule> CorsRules { get { throw null; } set { } }
public Azure.Provisioning.BicepValue<Azure.Core.ResourceIdentifier> Id { get { throw null; } }
public Azure.Provisioning.BicepValue<string> Name { get { throw null; } }
public Azure.Provisioning.Storage.StorageAccount? Parent { get { throw null; } set { } }
public Azure.Provisioning.Resources.SystemData SystemData { get { throw null; } }
protected override void DefineProvisionableProperties() { }
Expand Down
14 changes: 6 additions & 8 deletions sdk/provisioning/Azure.Provisioning.Storage/src/Generated/QueueService.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions sdk/provisioning/Azure.Provisioning.Storage/src/QueueService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

using Azure.Provisioning.Expressions;

namespace Azure.Provisioning.Storage;

// Customize the generated FileService resource.
public partial class QueueService
{
/// <summary>
/// Get the default value for the Name property.
/// </summary>
private partial BicepValue<string> GetNameDefaultValue() =>
new StringLiteralExpression("default");
}
1 change: 1 addition & 0 deletions sdk/provisioning/Generator/src/Specifications/StorageSpecification.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ protected override void Customize()
CustomizeProperty<StorageAccountManagementPolicyResource>("Name", p => { p.GenerateDefaultValue = true; p.HideAccessors = true; p.IsReadOnly = false; }); // must be `default`
AddNameRequirements<StorageQueueResource>(min: 3, max: 63, lower: true, digits: true, hyphen: true);
AddNameRequirements<TableResource>(min: 3, max: 63, lower: true, upper: true, digits: true);
CustomizeProperty<QueueServiceResource>("Name", p => { p.GenerateDefaultValue = true; p.HideAccessors = true; p.IsReadOnly = false; }); // must be `default`

// Roles
Roles.Add(new Role("StorageAccountBackupContributor", "e5e2a7ff-d759-4cd2-bb51-3152d37e2eb1", "Lets you perform backup and restore operations using Azure Backup on the storage account."));
Expand Down
Loading