Assign default name to QueueService #49672
Open
+34
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated QueueService to use `default` for the name property value as per the spec https://learn.microsoft.com/en-us/azure/templates/microsoft.storage/storageaccounts/queueservices?pivots=deployment-language-bicep
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @kzhen! We will review the pull request and get back to you soon. |
|
I've raised this PR after trying to create storage queues during deployment via Aspire - details with a reproduction |
16 tasks
RussKie
reviewed
May 7, 2025
| @@ -781,7 +781,6 @@ public partial class QueueService : Azure.Provisioning.Primitives.ProvisionableR | |||
| public QueueService(string bicepIdentifier, string? resourceVersion = null) : base (default(string), default(Azure.Core.ResourceType), default(string)) { } | |||
| public Azure.Provisioning.BicepList<Azure.Provisioning.Storage.StorageCorsRule> CorsRules { get { throw null; } set { } } | |||
| public Azure.Provisioning.BicepValue<Azure.Core.ResourceIdentifier> Id { get { throw null; } } | |||
| public Azure.Provisioning.BicepValue<string> Name { get { throw null; } } | |||
There was a problem hiding this comment.
This member can't be deleted this, it's a part of the public API surface
|
dotnet/aspire#9137 is blocked by the same issue. |
|
API change check API changes are not detected in this pull request. |
ArcturusZhang
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49898
Updated QueueService to use
defaultfor the name property value as per the spec https://learn.microsoft.com/en-us/azure/templates/microsoft.storage/storageaccounts/queueservices?pivots=deployment-language-bicepContributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.