[Storage] Data Lake Typing and API View Feedback #40096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
weirongw23-msft
commented
Mar 17, 2025
weirongw23-msft
commented
- Will need to discuss blob dependency (12.25.0 GA or 12.26.0b1 Unreleased Beta)
- Will need to update the release date after API Views have been approved
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the versioning and metadata for the azure-storage-file-datalake package to reflect a move from beta to production/stable status and incorporates changes related to type hinting improvements.
- Updated the package status in setup.py from "Beta" to "Production/Stable" and revised the azure-storage-blob dependency version.
- Revised the package version in _version.py from "12.20.0b1" to "12.20.0" to align with a stable release.
- Adjusted the CHANGELOG.md to reflect the updated version number and included notes on type hinting changes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/storage/azure-storage-file-datalake/setup.py | Updated development status and dependency version for a production/stable release. |
| sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_version.py | Removed beta marker from the package version. |
| sdk/storage/azure-storage-file-datalake/CHANGELOG.md | Updated version references and added a note for type hint improvements. |
Comments suppressed due to low confidence (1)
sdk/storage/azure-storage-file-datalake/setup.py:81
- The dependency version for azure-storage-blob has been changed to 12.25.0. Please verify that this version aligns with the intended production/stable release strategy, as the PR metadata indicates a discussion around using 12.25.0 GA versus 12.26.0b1.
"azure-storage-blob>=12.25.0",
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
weirongw23-msft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.