Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Data Lake Typing and API View Feedback #40096

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Storage] Data Lake Typing and API View Feedback #40096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
00cbce7
Changelog entries for datalake typing release
weirongw23-msft Mar 17, 2025
dc03324
Trying beta dependency to see if mypy passes
weirongw23-msft Mar 17, 2025
6b09ec9
Fixed type annotations for data in upload_data
weirongw23-msft Mar 17, 2025
8edc06e
Removed unused imports
weirongw23-msft Mar 18, 2025
7175778
Merge branch 'main' into weirongw23/datalake-typing-changelogs
weirongw23-msft Mar 18, 2025
90718fe
Updated versions for blob patch release. TODO: Review blob notes
weirongw23-msft Mar 18, 2025
df63b9b
Updated versions for blob patch release. TODO: Review blob notes
weirongw23-msft Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sdk/storage/azure-storage-blob/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# Release History

## 12.26.0b1 (Unreleased)
## 12.26.0 (2025-03-25)

### Features Added
### Other Changes
- Updated dependency for `azure-storage-file-datalake` type hints.

## 12.25.0 (2025-03-11)

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-blob/azure/storage/blob/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
# license information.
# --------------------------------------------------------------------------

VERSION = "12.26.0b1"
VERSION = "12.26.0"
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-blob/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
url='https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/storage/azure-storage-blob',
keywords="azure, azure sdk",
classifiers=[
'Development Status :: 4 - Beta',
'Development Status :: 5 - Production/Stable',
'Programming Language :: Python',
'Programming Language :: Python :: 3 :: Only',
'Programming Language :: Python :: 3',
Expand Down
3 changes: 2 additions & 1 deletion sdk/storage/azure-storage-file-datalake/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# Release History

## 12.20.0b1 (Unreleased)
## 12.20.0 (2025-03-25)

### Features Added
- Updated type hints across the entire package and enabled MyPy to run during CI. Some public types may have been adjusted if they were previously erroneous or incomplete.

## 12.19.0 (2025-03-11)

Expand Down
6 changes: 3 additions & 3 deletions sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_file_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from datetime import datetime
from typing import (
Any, AnyStr, AsyncIterable, cast, Dict, IO, Iterable, Optional, Union,
Any, AnyStr, cast, Dict, IO, Iterable, Optional, Union,
TYPE_CHECKING
)
from urllib.parse import quote, unquote
Expand Down Expand Up @@ -379,7 +379,7 @@ def set_file_expiry(

@distributed_trace
def upload_data(
self, data: Union[bytes, str, Iterable[AnyStr], AsyncIterable[AnyStr], IO[AnyStr]],
self, data: Union[bytes, str, Iterable[AnyStr], IO[AnyStr]],
length: Optional[int] = None,
overwrite: Optional[bool] = False,
**kwargs: Any
Expand All @@ -388,7 +388,7 @@ def upload_data(
Upload data to a file.

:param data: Content to be uploaded to file
:type data: bytes, str, Iterable[AnyStr], AsyncIterable[AnyStr], or IO[AnyStr]
:type data: bytes, str, Iterable[AnyStr], or IO[AnyStr]
:param int length: Size of the data in bytes.
:param bool overwrite: to overwrite an existing file or not.
:keyword ~azure.storage.filedatalake.ContentSettings content_settings:
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
# license information.
# --------------------------------------------------------------------------

VERSION = "12.20.0b1"
VERSION = "12.20.0"
10 changes: 5 additions & 5 deletions ...zure-storage-file-datalake/azure/storage/filedatalake/aio/_data_lake_file_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from datetime import datetime
from typing import (
Any, AnyStr, AsyncIterable, cast, Dict, IO, Iterable, Optional, Union,
Any, AnyStr, AsyncIterable, cast, Dict, IO, Optional, Union,
TYPE_CHECKING
)
from urllib.parse import quote, unquote
Expand Down Expand Up @@ -395,7 +395,7 @@ async def set_file_expiry(

@distributed_trace_async
async def upload_data(
self, data: Union[bytes, str, Iterable[AnyStr], AsyncIterable[AnyStr], IO[AnyStr]],
self, data: Union[bytes, str, AsyncIterable[AnyStr], IO[AnyStr]],
length: Optional[int] = None,
overwrite: Optional[bool] = False,
**kwargs: Any
Expand All @@ -404,7 +404,7 @@ async def upload_data(
Upload data to a file.

:param data: Content to be uploaded to file
:type data: bytes, str, Iterable[AnyStr], AsyncIterable[AnyStr], or IO[AnyStr]
:type data: bytes, str, AsyncIterable[AnyStr], or IO[AnyStr]
:param int length: Size of the data in bytes.
:param bool overwrite: to overwrite an existing file or not.
:keyword ~azure.storage.filedatalake.ContentSettings content_settings:
Expand Down Expand Up @@ -489,15 +489,15 @@ async def upload_data(

@distributed_trace_async
async def append_data(
self, data: Union[bytes, str, Iterable[AnyStr], IO[AnyStr]],
self, data: Union[bytes, str, AsyncIterable[AnyStr], IO[AnyStr]],
offset: int,
length: Optional[int] = None,
**kwargs: Any
) -> Dict[str, Any]:
"""Append data to the file.

:param data: Content to be appended to file
:type data: bytes, str, Iterable[AnyStr], or IO[AnyStr]
:type data: bytes, str, AsyncIterable[AnyStr], or IO[AnyStr]
:param int offset: start position of the data to be appended to.
:param length: Size of the data in bytes.
:type length: int or None
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/azure-storage-file-datalake/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
url='https://github.com/Azure/azure-sdk-for-python',
keywords="azure, azure sdk",
classifiers=[
'Development Status :: 4 - Beta',
'Development Status :: 5 - Production/Stable',
'Programming Language :: Python',
'Programming Language :: Python :: 3 :: Only',
'Programming Language :: Python :: 3',
Expand All @@ -78,7 +78,7 @@
python_requires=">=3.8",
install_requires=[
"azure-core>=1.30.0",
"azure-storage-blob>=12.26.0b1",
"azure-storage-blob>=12.26.0",
"typing-extensions>=4.6.0",
"isodate>=0.6.1"
],
Expand Down