Mar25/icm/id based run paths #40126
Open
Mar25/icm/id based run paths #40126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Evaluation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug causing local evaluation runs with the same name to share and overwrite artifact files by switching the uploaded run identifier from run_name to run_id.
- Updated changelog to document the behavior change.
- Modified the artifact upload path to use the run_id instead of run_name.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/evaluation/azure-ai-evaluation/CHANGELOG.md | Updated changelog entry to document the fix for file conflicts during uploads. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_eval_run.py | Updated the upload path to use run_id to prevent result file collisions. |
Comment on lines
+46
to
47
| - Uploading local evaluation results from `evaluate` with the name run name will no longer result in each online run sharing (and bashing) result files. | ||
|
|
There was a problem hiding this comment.
[nitpick] The changelog entry contains unclear wording. Consider rephrasing it to clearly state that local evaluation results are now stored using the unique run ID to avoid file sharing conflicts.
Suggested change
| - Uploading local evaluation results from `evaluate` with the name run name will no longer result in each online run sharing (and bashing) result files. | |
| - Local evaluation results from `evaluate` are now stored using the unique run ID to avoid file sharing conflicts. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
w-javed
reviewed
Mar 18, 2025
| @@ -43,6 +43,7 @@ | |||
|
|
|||
| ### Bugs Fixed | |||
| - Fixed error in `GroundednessProEvaluator` when handling non-numeric values like "n/a" returned from the service. | |||
| - Uploading local evaluation results from `evaluate` with the name run name will no longer result in each online run sharing (and bashing) result files. | |||
There was a problem hiding this comment.
typo: with the name run name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug addressed by an ICM which causes the uploaded results of local evaluation runs with the same name to use the same file to store results, which causes older runs to have their results bashed and replaced by newer runs.