Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mar25/icm/id based run paths #40126

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

Mar25/icm/id based run paths #40126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b39e2c5
use run id instead of name for storing files
MilesHolland Mar 18, 2025
80769ab
CL
MilesHolland Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/evaluation/azure-ai-evaluation/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@

### Bugs Fixed
- Fixed error in `GroundednessProEvaluator` when handling non-numeric values like "n/a" returned from the service.
- Uploading local evaluation results from `evaluate` with the name run name will no longer result in each online run sharing (and bashing) result files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: with the name run name


Comment on lines +46 to 47
Copy link
Preview

Copilot AI Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The changelog entry contains unclear wording. Consider rephrasing it to clearly state that local evaluation results are now stored using the unique run ID to avoid file sharing conflicts.

Suggested change
- Uploading local evaluation results from `evaluate` with the name run name will no longer result in each online run sharing (and bashing) result files.
- Local evaluation results from `evaluate` are now stored using the unique run ID to avoid file sharing conflicts.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
### Other Changes

Expand Down
2 changes: 1 addition & 1 deletion sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_eval_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ def log_artifact(self, artifact_folder: str, artifact_name: str = EVALUATION_ART
LOGGER.warning("The run results file was not found, skipping artifacts upload.")
return
# First we will list the files and the appropriate remote paths for them.
root_upload_path = posixpath.join("promptflow", "PromptFlowArtifacts", self.info.run_name)
root_upload_path = posixpath.join("promptflow", "PromptFlowArtifacts", self.info.run_id)
remote_paths: Dict[str, List[Dict[str, str]]] = {"paths": []}
local_paths = []
# Go over the artifact folder and upload all artifacts.
Expand Down