refactor --check-type and --package-path and service initialization for language repos by l0lawrence · Pull Request #11779 · Azure/azure-sdk-tools

l0lawrence · 2025-08-21T17:57:03Z

No description provided.

…refactorservice

Copilot

Pull Request Overview

This PR refactors the package checking tool to replace the factory pattern with a composition-based approach for language-specific validations. The main goal is to modernize the architecture by using dependency injection and a more flexible language detection mechanism.

Replaced --check-type option parameter with individual sub-commands for each check type
Changed --package-path option to default to current directory instead of being required
Replaced inheritance-based language services with composition-based language-specific checks

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
PackageCheckTool.cs	Refactored command structure to use sub-commands instead of options, updated to use ILanguageChecks interface
ServiceRegistrations.cs	Updated DI container to register new composition-based language check services
LanguageSpecificCheckResolver.cs	New resolver service for detecting and selecting appropriate language-specific check implementations
PythonLanguageSpecificChecks.cs	New composition-based Python language check implementation
JavaScriptLanguageSpecificChecks.cs	New composition-based JavaScript language check implementation
JavaLanguageSpecificChecks.cs	New composition-based Java language check implementation
GoLanguageSpecificChecks.cs	New composition-based Go language check implementation
DotNetLanguageSpecificChecks.cs	New composition-based .NET language check implementation
LanguageChecks.cs	New unified language checks service that delegates to language-specific implementations
ILanguageSpecificChecks.cs	New interface defining the contract for language-specific check implementations
CLICheckResponse.cs	Added utility method for creating responses from process results
SharedOptions.cs	Updated PackagePath option to use current directory as default and made it optional

Comments suppressed due to low confidence (1)

tools/azsdk-cli/Azure.Sdk.Tools.Cli/Tools/Package/PackageCheckTool.cs:31

The SupportedLanguage property returns "JavaScript" but the LanguageSpecificCheckResolver expects language names to match what's extracted from Language-Settings.ps1. Based on the resolver's detection logic, this should likely be "js" or another value that matches the PowerShell script output.

            this.languageChecks = languageChecks;

Co-authored-by: Timo van Veenendaal <timov@microsoft.com>

…iptLanguageSpecificChecks.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…-sdk-tools into refactorservice

benbp

Some nits, LGTM

…ageSpecificChecks.cs Co-authored-by: Ben Broderick Phillips <ben@benbp.net>

…-sdk-tools into refactorservice

…zation for language repos (Azure#11779)" This reverts commit d2dfe8f.

…or language repos (#11779) * this? * this * need to fix * do not need a default it will do nothing * remove default * updating * update package tool * add Go * rename * add .net and java * add other lang outline * spelling * make a helper func * nit * renames * update checks * also update CLI tool command to remove check-type * can_handle higher level, add interfaces for mocking * remove checkHelper * make var private * set default current working directory * run pwsh command * Update tools/azsdk-cli/Azure.Sdk.Tools.Cli/Commands/SharedOptions.cs Co-authored-by: Timo van Veenendaal <timov@microsoft.com> * dotnet * Update tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/JavaScriptLanguageSpecificChecks.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * constructor overload * Update tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/GoLanguageSpecificChecks.cs Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * correcting code --------- Co-authored-by: Timo van Veenendaal <timov@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net>

…or language repos (Azure#11779) * this? * this * need to fix * do not need a default it will do nothing * remove default * updating * update package tool * add Go * rename * add .net and java * add other lang outline * spelling * make a helper func * nit * renames * update checks * also update CLI tool command to remove check-type * can_handle higher level, add interfaces for mocking * remove checkHelper * make var private * set default current working directory * run pwsh command * Update tools/azsdk-cli/Azure.Sdk.Tools.Cli/Commands/SharedOptions.cs Co-authored-by: Timo van Veenendaal <timov@microsoft.com> * dotnet * Update tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/JavaScriptLanguageSpecificChecks.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * constructor overload * Update tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/GoLanguageSpecificChecks.cs Co-authored-by: Ben Broderick Phillips <ben@benbp.net> * correcting code --------- Co-authored-by: Timo van Veenendaal <timov@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ben Broderick Phillips <ben@benbp.net>

github-actions Bot added the azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli label Aug 21, 2025

this?

7798ec9

l0lawrence force-pushed the refactorservice branch from 1028d54 to 7798ec9 Compare August 21, 2025 20:33

l0lawrence added 16 commits August 21, 2025 13:39

this

1bc7210

need to fix

c9184de

do not need a default it will do nothing

27533da

remove default

5d8f77a

updating

a5830b9

update package tool

bc4fdcc

add Go

a274e08

rename

b984325

add .net and java

ba78bb3

add other lang outline

1e6ce88

spelling

e5c9b31

make a helper func

ad0cdc3

nit

a5af93b

renames

06d496d

update checks

7792c0d

also update CLI tool command to remove check-type

a9057dc

timovv reviewed Aug 26, 2025

View reviewed changes

l0lawrence added 6 commits August 26, 2025 09:54

Merge branch 'main' of https://github.com/Azure/azure-sdk-tools into …

4555c98

…refactorservice

can_handle higher level, add interfaces for mocking

d6e7d55

remove checkHelper

0eadbb6

make var private

6e38375

set default current working directory

54ba0eb

run pwsh command

0a88b70

timovv reviewed Aug 27, 2025

View reviewed changes

Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Commands/SharedOptions.cs Outdated

Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Commands/SharedOptions.cs

l0lawrence changed the title ~~refactor~~ refactor --check-type and --package-path and service initialization for language repos Aug 27, 2025

l0lawrence commented Aug 27, 2025

View reviewed changes

Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/LanguageSpecificCheckResolver.cs

l0lawrence marked this pull request as ready for review August 27, 2025 16:35

Copilot AI review requested due to automatic review settings August 27, 2025 16:35

l0lawrence requested review from benbp, jeo02, maririos, praveenkuttappan, richardpark-msft, samvaity, scbedd and smw-ms as code owners August 27, 2025 16:35

Copilot AI reviewed Aug 27, 2025

View reviewed changes

l0lawrence and others added 4 commits August 27, 2025 09:47

Update tools/azsdk-cli/Azure.Sdk.Tools.Cli/Commands/SharedOptions.cs

7260031

Co-authored-by: Timo van Veenendaal <timov@microsoft.com>

dotnet

e77f431

Update tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/JavaScr…

d12c7b0

…iptLanguageSpecificChecks.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'refactorservice' of https://github.com/l0lawrence/azure…

e3cdf17

…-sdk-tools into refactorservice

benbp reviewed Aug 27, 2025

View reviewed changes

Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Models/Responses/CLICheckResponse.cs Outdated

benbp reviewed Aug 27, 2025

View reviewed changes

Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/GoLanguageSpecificChecks.cs

benbp reviewed Aug 27, 2025

View reviewed changes

Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/GoLanguageSpecificChecks.cs Outdated

benbp reviewed Aug 27, 2025

View reviewed changes

Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/LanguageSpecificCheckResolver.cs Outdated

benbp approved these changes Aug 27, 2025

View reviewed changes

l0lawrence and others added 4 commits August 27, 2025 10:51

constructor overload

f49d178

Update tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/GoLangu…

a865eb1

…ageSpecificChecks.cs Co-authored-by: Ben Broderick Phillips <ben@benbp.net>

correcting code

6a94194

Merge branch 'refactorservice' of https://github.com/l0lawrence/azure…

41cb1e7

…-sdk-tools into refactorservice

timovv approved these changes Aug 27, 2025

View reviewed changes

l0lawrence merged commit d2dfe8f into Azure:main Aug 27, 2025
13 checks passed

l0lawrence added a commit to l0lawrence/azure-sdk-tools that referenced this pull request Aug 28, 2025

Revert "refactor --check-type and --package-path and service initiali…

7fd53b0

…zation for language repos (Azure#11779)" This reverts commit d2dfe8f.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor --check-type and --package-path and service initialization for language repos#11779

refactor --check-type and --package-path and service initialization for language repos#11779
l0lawrence merged 31 commits into
Azure:mainfrom
l0lawrence:refactorservice

l0lawrence commented Aug 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benbp left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

l0lawrence commented Aug 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benbp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants