-
Notifications
You must be signed in to change notification settings - Fork 240
refactor --check-type and --package-path and service initialization for language repos #11779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 27 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
7798ec9
this?
l0lawrence 1bc7210
this
l0lawrence c9184de
need to fix
l0lawrence 27533da
do not need a default it will do nothing
l0lawrence 5d8f77a
remove default
l0lawrence a5830b9
updating
l0lawrence bc4fdcc
update package tool
l0lawrence a274e08
add Go
l0lawrence b984325
rename
l0lawrence ba78bb3
add .net and java
l0lawrence 1e6ce88
add other lang outline
l0lawrence e5c9b31
spelling
l0lawrence ad0cdc3
make a helper func
l0lawrence a5af93b
nit
l0lawrence 06d496d
renames
l0lawrence 7792c0d
update checks
l0lawrence a9057dc
also update CLI tool command to remove check-type
l0lawrence 4555c98
Merge branch 'main' of https://github.com/Azure/azure-sdk-tools into …
l0lawrence d6e7d55
can_handle higher level, add interfaces for mocking
l0lawrence 0eadbb6
remove checkHelper
l0lawrence 6e38375
make var private
l0lawrence 54ba0eb
set default current working directory
l0lawrence 0a88b70
run pwsh command
l0lawrence 7260031
Update tools/azsdk-cli/Azure.Sdk.Tools.Cli/Commands/SharedOptions.cs
l0lawrence e77f431
dotnet
l0lawrence d12c7b0
Update tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/JavaScr…
l0lawrence e3cdf17
Merge branch 'refactorservice' of https://github.com/l0lawrence/azure…
l0lawrence f49d178
constructor overload
l0lawrence a865eb1
Update tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/GoLangu…
l0lawrence 6a94194
correcting code
l0lawrence 41cb1e7
Merge branch 'refactorservice' of https://github.com/l0lawrence/azure…
l0lawrence File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 0 additions & 18 deletions
18
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/DotNetLanguageRepoService.cs
This file was deleted.
Oops, something went wrong.
38 changes: 38 additions & 0 deletions
38
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/DotNetLanguageSpecificChecks.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| using System.Runtime.InteropServices; | ||
| using Azure.Sdk.Tools.Cli.Models; | ||
| using Azure.Sdk.Tools.Cli.Helpers; | ||
| using Microsoft.Extensions.Logging; | ||
|
|
||
| namespace Azure.Sdk.Tools.Cli.Services; | ||
|
|
||
| /// <summary> | ||
| /// .NET-specific implementation of language repository service. | ||
| /// Uses tools like dotnet CLI, MSBuild, NuGet, etc. for .NET development workflows. | ||
| /// </summary> | ||
| public class DotNetLanguageSpecificChecks : ILanguageSpecificChecks | ||
| { | ||
| private readonly IProcessHelper _processHelper; | ||
| private readonly INpxHelper _npxHelper; | ||
| private readonly IGitHelper _gitHelper; | ||
| private readonly ILogger<DotNetLanguageSpecificChecks> _logger; | ||
|
|
||
| public DotNetLanguageSpecificChecks( | ||
| IProcessHelper processHelper, | ||
| INpxHelper npxHelper, | ||
| IGitHelper gitHelper, | ||
| ILogger<DotNetLanguageSpecificChecks> logger) | ||
| { | ||
| _processHelper = processHelper; | ||
| _npxHelper = npxHelper; | ||
| _gitHelper = gitHelper; | ||
| _logger = logger; | ||
| } | ||
|
|
||
| public string SupportedLanguage => "dotnet"; | ||
|
|
||
| public async Task<CLICheckResponse> AnalyzeDependenciesAsync(string packagePath, CancellationToken ct) | ||
| { | ||
| // Implementation for analyzing dependencies in a .NET project | ||
| return await Task.FromResult(new CLICheckResponse()); | ||
| } | ||
| } |
150 changes: 0 additions & 150 deletions
150
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Languages/GoLanguageRepoService.cs
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.