Skip to content

Conversation

@taustgen
Copy link
Contributor

@taustgen taustgen commented Apr 16, 2025

Describe your changes

Makes the upgrade_override block configurable on the kubernetes cluster.
This is important because if force upgrade is ever used via the cli the cluster cannot be modified via terraform unless that block is present.

Context:
I used the force-upgrade via the CLI to upgrade one of my clusters back in November. The upgrade_override block was detected and state updated. Now months later im starting the next upgrade cycle and this cluster cannot be updated as the upgrade_override block cannot be removed if present

Issue number

Screenshot 2025-04-16 at 2 10 00 PM


│ Error: `upgrade_override` cannot be unset
│
│   with module.aks.azurerm_kubernetes_cluster.main,
│   on ../azure-aks-azurerm/v4/main.tf line 13, in resource "azurerm_kubernetes_cluster" "main":
│   13: resource "azurerm_kubernetes_cluster" "main" {
│
╵

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@taustgen taustgen marked this pull request as ready for review April 16, 2025 21:12
@lonegunmanb lonegunmanb changed the base branch from main to add-force-upgrade-block April 18, 2025 02:14
@lonegunmanb
Copy link
Member

Thanks @taustgen , just about time!

@lonegunmanb lonegunmanb merged commit ea69358 into Azure:add-force-upgrade-block Apr 18, 2025
2 of 4 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Azure Module Kanban Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants